* [PATCH] mm,hwpoison: Fix printing of page flags
@ 2021-01-08 8:52 Oscar Salvador
2021-01-08 9:29 ` Anshuman Khandual
2021-01-08 10:09 ` HORIGUCHI NAOYA(堀口 直也)
0 siblings, 2 replies; 3+ messages in thread
From: Oscar Salvador @ 2021-01-08 8:52 UTC (permalink / raw)
To: akpm; +Cc: n-horiguchi, dan.carpenter, linux-mm, linux-kernel, Oscar Salvador
Format %pG expects a lower case 'p' in order to print the flags.
Fix it.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page")
---
mm/memory-failure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 5a38e9eade94..04d9f154a130 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags)
goto retry;
}
} else if (ret == -EIO) {
- pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n",
+ pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
__func__, pfn, page->flags, &page->flags);
}
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm,hwpoison: Fix printing of page flags
2021-01-08 8:52 [PATCH] mm,hwpoison: Fix printing of page flags Oscar Salvador
@ 2021-01-08 9:29 ` Anshuman Khandual
2021-01-08 10:09 ` HORIGUCHI NAOYA(堀口 直也)
1 sibling, 0 replies; 3+ messages in thread
From: Anshuman Khandual @ 2021-01-08 9:29 UTC (permalink / raw)
To: Oscar Salvador, akpm; +Cc: n-horiguchi, dan.carpenter, linux-mm, linux-kernel
On 1/8/21 2:22 PM, Oscar Salvador wrote:
> Format %pG expects a lower case 'p' in order to print the flags.
> Fix it.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page")
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> mm/memory-failure.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 5a38e9eade94..04d9f154a130 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags)
> goto retry;
> }
> } else if (ret == -EIO) {
> - pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n",
> + pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
> __func__, pfn, page->flags, &page->flags);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm,hwpoison: Fix printing of page flags
2021-01-08 8:52 [PATCH] mm,hwpoison: Fix printing of page flags Oscar Salvador
2021-01-08 9:29 ` Anshuman Khandual
@ 2021-01-08 10:09 ` HORIGUCHI NAOYA(堀口 直也)
1 sibling, 0 replies; 3+ messages in thread
From: HORIGUCHI NAOYA(堀口 直也) @ 2021-01-08 10:09 UTC (permalink / raw)
To: Oscar Salvador; +Cc: akpm, n-horiguchi, dan.carpenter, linux-mm, linux-kernel
On Fri, Jan 08, 2021 at 09:52:02AM +0100, Oscar Salvador wrote:
> Format %pG expects a lower case 'p' in order to print the flags.
> Fix it.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page")
Thank you!
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-08 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 8:52 [PATCH] mm,hwpoison: Fix printing of page flags Oscar Salvador
2021-01-08 9:29 ` Anshuman Khandual
2021-01-08 10:09 ` HORIGUCHI NAOYA(堀口 直也)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox