From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657E0C433E0 for ; Thu, 7 Jan 2021 13:18:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AA4922475 for ; Thu, 7 Jan 2021 13:18:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AA4922475 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D1DF8D0139; Thu, 7 Jan 2021 08:18:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 482446B02E1; Thu, 7 Jan 2021 08:18:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 396E08D0139; Thu, 7 Jan 2021 08:18:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 23C666B02C1 for ; Thu, 7 Jan 2021 08:18:48 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E85EC2C8B for ; Thu, 7 Jan 2021 13:18:47 +0000 (UTC) X-FDA: 77679033894.29.birth72_5417e67274ea Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id C90A8180868D3 for ; Thu, 7 Jan 2021 13:18:47 +0000 (UTC) X-HE-Tag: birth72_5417e67274ea X-Filterd-Recvd-Size: 4614 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 13:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610025526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LD2V9ZmDJck9nrtp+0qP7602QSITv2R4SHWYRUA24HM=; b=AeJxY7hrZF9kQPN5ndYeZVo/Z3VsJosuH64dg/fF6MDOOvj84Jxw4IZUnt7AT0/O8J2E1a 24jlAWlt4RMmJHn8qkNmA17KPl7j5W8fR0igB5SCL8dRksObj9I756b+IPAOR2D7JJMRhW gkMrrYiQO+VqI7H6ShXl0Zcr18diuLQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-zvzF2XRtP1uRRXUpQpVxgA-1; Thu, 07 Jan 2021 08:18:42 -0500 X-MC-Unique: zvzF2XRtP1uRRXUpQpVxgA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCB18800D62; Thu, 7 Jan 2021 13:18:41 +0000 (UTC) Received: from localhost (ovpn-12-191.pek2.redhat.com [10.72.12.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30E475C8AA; Thu, 7 Jan 2021 13:18:37 +0000 (UTC) Date: Thu, 7 Jan 2021 21:18:35 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v3 2/4] mm: simplify parater of function memmap_init_zone() Message-ID: <20210107131835.GD4820@MiWiFi-R3L-srv> References: <20210105074708.18483-1-bhe@redhat.com> <20210105074708.18483-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/05/21 at 05:53pm, David Hildenbrand wrote: > [...] > > > -void __meminit > > -memmap_init_zone(unsigned long size, int nid, unsigned long zone, > > - unsigned long start_pfn) > > +void __meminit memmap_init_zone(struct zone *zone) > > { > > + unsigned long size = zone->spanned_pages; > > + int nid = zone_to_nid(zone), zone_id = zone_idx(zone); > > + unsigned long start_pfn = zone->zone_start_pfn; > > + > > Nit: reverse Christmas tree. Ah, yes, I will reorder these lines. > > > if (!vmem_map) { > > - memmap_init_range(size, nid, zone, start_pfn, start_pfn + size, > > + memmap_init_range(size, nid, zone_id, start_pfn, start_pfn + size, > > MEMINIT_EARLY, NULL, MIGRATE_MOVABLE); > > } else { > > struct page *start; > > @@ -556,7 +558,7 @@ memmap_init_zone(unsigned long size, int nid, unsigned long zone, > > args.start = start; > > args.end = start + size; > > args.nid = nid; > > - args.zone = zone; > > + args.zone = zone_id; > > > > efi_memmap_walk(virtual_memmap_init, &args); > > } > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 69ebf75be91c..b2a46ffdaf0b 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -6292,16 +6292,16 @@ static inline u64 init_unavailable_range(unsigned long spfn, unsigned long epfn, > > } > > #endif > > > > -void __init __weak memmap_init_zone(unsigned long size, int nid, > > - unsigned long zone, > > - unsigned long zone_start_pfn) > > +void __init __weak memmap_init_zone(struct zone *zone) > > { > > unsigned long start_pfn, end_pfn, hole_start_pfn = 0; > > - unsigned long zone_end_pfn = zone_start_pfn + size; > > + int i, nid = zone_to_nid(zone), zone_id = zone_idx(zone); > > + unsigned long zone_start_pfn = zone->zone_start_pfn; > > + unsigned long zone_end_pfn = zone_start_pfn + zone->spanned_pages; > > dito. OK. > > > u64 pgcnt = 0; > > - int i; > > > > for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) { > > + unsigned long size; > > You can just get rid of this parameter IMHO. Someone possibly like a intermediate local variable better in this case, but I am fine to both, will change as you suggested. > > (Also, there is an empty line missing right now) Sure. Thanks. > > > Apart from that LGTM > > -- > Thanks, > > David / dhildenb