From: Michal Hocko <mhocko@suse.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <ak@linux.intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Yang Shi <shy828301@gmail.com>
Subject: Re: [External] Re: [PATCH v2 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one
Date: Thu, 7 Jan 2021 12:48:06 +0100 [thread overview]
Message-ID: <20210107114806.GI13207@dhcp22.suse.cz> (raw)
In-Reply-To: <CAMZfGtULi=E5pNoLciaedGfNpSdopzyOzFhnzALf+nCciFRUPQ@mail.gmail.com>
On Thu 07-01-21 19:24:59, Muchun Song wrote:
> On Thu, Jan 7, 2021 at 7:16 PM Michal Hocko <mhocko@suse.com> wrote:
> >
> > On Thu 07-01-21 10:52:21, Muchun Song wrote:
> > > On Thu, Jan 7, 2021 at 12:13 AM Michal Hocko <mhocko@suse.com> wrote:
> > > >
> > > > On Wed 06-01-21 16:47:34, Muchun Song wrote:
> > > > > If the refcount is one when it is migrated, it means that the page
> > > > > was freed from under us. So we are done and do not need to migrate.
> > > >
> > > > Is this common enough that it would warrant the explicit check for each
> > > > migration?
> > >
> > > Are you worried about the overhead caused by the check? Thanks.
> >
> > I am not as worried as I would like to see some actual justification for
> > this optimization.
>
> OK. The HugeTLB page can be freed after it was isolated but before
> being migrated. Right? If we catch this case, it is an optimization.
> I do this just like unmap_and_move() does for a base page.
If your only justification is that this path to be consistent with the
regular pages then make it explicit in the changelog. Please think of
people reading this code in the future and scratching their heads
whether this is something that can be altered and fail to find the
reasoning. Was this a huge optimization and some workload might suffer?
Can this happen in the first place or how likely it is?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-01-07 11:48 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 8:47 [PATCH v2 0/6] Fix some bugs about HugeTLB code Muchun Song
2021-01-06 8:47 ` [PATCH v2 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-06 16:13 ` Michal Hocko
2021-01-07 2:52 ` [External] " Muchun Song
2021-01-07 11:16 ` Michal Hocko
2021-01-07 11:24 ` Muchun Song
2021-01-07 11:48 ` Michal Hocko [this message]
2021-01-06 8:47 ` [PATCH v2 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-06 16:35 ` Michal Hocko
2021-01-06 19:30 ` Mike Kravetz
2021-01-06 20:02 ` Michal Hocko
2021-01-06 21:07 ` Mike Kravetz
2021-01-07 8:36 ` Michal Hocko
2021-01-07 2:58 ` [External] " Muchun Song
2021-01-06 8:47 ` [PATCH v2 3/6] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-06 16:56 ` Michal Hocko
2021-01-06 20:58 ` Mike Kravetz
2021-01-07 3:08 ` [External] " Muchun Song
2021-01-07 8:40 ` Michal Hocko
2021-01-08 0:52 ` Mike Kravetz
2021-01-08 8:28 ` Michal Hocko
2021-01-07 5:39 ` [External] " Muchun Song
2021-01-07 8:41 ` Michal Hocko
2021-01-07 8:53 ` Muchun Song
2021-01-07 11:18 ` Michal Hocko
2021-01-07 11:38 ` Muchun Song
2021-01-07 12:38 ` Michal Hocko
2021-01-07 12:59 ` Muchun Song
2021-01-07 14:11 ` Michal Hocko
2021-01-07 15:11 ` Muchun Song
2021-01-08 1:06 ` Mike Kravetz
2021-01-08 2:38 ` Muchun Song
2021-01-08 8:43 ` Michal Hocko
2021-01-08 9:01 ` Muchun Song
2021-01-08 9:31 ` Michal Hocko
2021-01-08 10:08 ` Muchun Song
2021-01-08 11:44 ` Michal Hocko
2021-01-08 11:52 ` Muchun Song
2021-01-08 12:04 ` Michal Hocko
2021-01-08 12:24 ` Muchun Song
2021-01-06 8:47 ` [PATCH v2 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page Muchun Song
2021-01-06 17:07 ` Michal Hocko
2021-01-07 3:11 ` [External] " Muchun Song
2021-01-07 8:39 ` Michal Hocko
2021-01-07 9:01 ` Muchun Song
2021-01-07 11:22 ` Michal Hocko
2021-01-06 8:47 ` [PATCH v2 5/6] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-06 17:10 ` Michal Hocko
2021-01-06 8:47 ` [PATCH v2 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
2021-01-06 17:16 ` Michal Hocko
2021-01-08 22:24 ` Mike Kravetz
2021-01-09 4:07 ` [External] " Muchun Song
2021-01-07 9:30 ` [PATCH v2 0/6] Fix some bugs about HugeTLB code David Hildenbrand
2021-01-07 9:40 ` [External] " Muchun Song
2021-01-07 10:10 ` David Hildenbrand
2021-01-07 10:16 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107114806.GI13207@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox