From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B42C433E0 for ; Thu, 7 Jan 2021 02:53:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 260CB22E03 for ; Thu, 7 Jan 2021 02:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 260CB22E03 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B9D78D0116; Wed, 6 Jan 2021 21:53:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76A0D8D0090; Wed, 6 Jan 2021 21:53:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A6A08D0116; Wed, 6 Jan 2021 21:53:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 553118D0090 for ; Wed, 6 Jan 2021 21:53:40 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1E2BF824556B for ; Thu, 7 Jan 2021 02:53:40 +0000 (UTC) X-FDA: 77677458600.03.woman54_0f0a580274e6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 0190C28A4E8 for ; Thu, 7 Jan 2021 02:53:39 +0000 (UTC) X-HE-Tag: woman54_0f0a580274e6 X-Filterd-Recvd-Size: 3520 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 02:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609988018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RlmE8gtKZ+mcWaD+9WFmA0/MsQMlwlKVF0NW+mmjFVw=; b=ItmOYK9CaO4wyouwSNtr1KtqB0JYHG8DTieJNjJoSfPpwiwC7e61YVl3I1rq6ox53n9hQt umppz7V60bpz0GtYhOrIY9aGssZWpCJa8PY5WtHaOQXFZV1Fmw40NjDrcV3q0oDrbSlb31 KIO1XfkzwY1Vvsht3Kif+YhlsM6pwso= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-iUQ3oHCiO2OS24FN5zkMfw-1; Wed, 06 Jan 2021 21:53:34 -0500 X-MC-Unique: iUQ3oHCiO2OS24FN5zkMfw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AE128180A094; Thu, 7 Jan 2021 02:53:32 +0000 (UTC) Received: from localhost (ovpn-12-191.pek2.redhat.com [10.72.12.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE5C752791; Thu, 7 Jan 2021 02:53:31 +0000 (UTC) Date: Thu, 7 Jan 2021 10:53:28 +0800 From: Baoquan He To: Andrew Morton Cc: Hugh Dickins , Hui Su , Alex Shi , Lorenzo Stoakes , Michal Hocko , Johannes Weiner , Shakeel Butt , Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec() Message-ID: <20210107025328.GB4820@MiWiFi-R3L-srv> References: <20210106064935.GA3338@MiWiFi-R3L-srv> <20210106113531.6f327d37eff78e4e1bb0e13a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106113531.6f327d37eff78e4e1bb0e13a@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/06/21 at 11:35am, Andrew Morton wrote: > On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > > > Fixes: 9a1ac2288cf1 ("mm/memcontrol:rewrite mem_cgroup_page_lruvec()") > > > > ... > > > > Thanks for fixing this. We also encountered this issue in kdump kernel > > with the mainline 5.10 kernel since 'cgroup_disable=memory' is added. > > Wait. 9a1ac2288cf1 isn't present in 5.10? > Yes, just checked, commit 9a1ac2288cf1 was merged in 5.11-rc1, not in 5.10.0. Seems Redhat CKI doesn't treat the kernel release correctly, it calls all kernel 5.11-rcx as 5.10.0. Sorry for the confusion, I will send mail to them to change this. I got the failure report from redhat's CKI test, the kernel repo is as below, but the subject of failure report and 'uname -r' told it's 5.10.0. Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Commit: 58cf05f597b0 - Merge tag 'sound-fix-5.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound