From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53416C433E0 for ; Wed, 6 Jan 2021 20:04:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB78A23131 for ; Wed, 6 Jan 2021 20:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB78A23131 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35B5F6B02B0; Wed, 6 Jan 2021 15:04:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30A556B02D2; Wed, 6 Jan 2021 15:04:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D20D6B02D3; Wed, 6 Jan 2021 15:04:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 079346B02B0 for ; Wed, 6 Jan 2021 15:04:57 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BDCE1824556B for ; Wed, 6 Jan 2021 20:04:56 +0000 (UTC) X-FDA: 77676428592.11.sea01_23088bd274e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 86461180F8B80 for ; Wed, 6 Jan 2021 20:04:56 +0000 (UTC) X-HE-Tag: sea01_23088bd274e4 X-Filterd-Recvd-Size: 9777 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 20:04:55 +0000 (UTC) Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 106K1SXq020097; Wed, 6 Jan 2021 12:04:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=facebook; bh=byyWW5EjJ5JP8YAPUP7I3603V15sHg9WrQ0YJy3sn4U=; b=ee6f5eYivxyCp+zi0tvro1sQ0XI1pIhHL39+nAPXYES6SpCsUd3S4mqzz8kc/+w2CBra w9oPUpobNxiYDjMUCW727BBR3Oql1WA0HdtXb3OQm5hi6x/kz4cpcTUYzUyERFy7bP1d txq6SY/GovsK3IdRt7Ei62ue5MmhX6n+SHc= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 35wjb0rjke-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 06 Jan 2021 12:04:49 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (100.104.98.9) by o365-in.thefacebook.com (100.104.94.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 6 Jan 2021 12:04:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSgz3PcV1Ym7PIcbUK++81reisbBymE7rcUg5xMNleOMrHF1c7kaQ2fKvI8VPnYIgRclii9IMJdOFlFg7IMY+Lchf7Qg/jdh3W5svJ6aV/o6o7mhMVT+/HeiwHa4LMFzbaQi+yidbsYU82ki1+EZNQt1kIOyIaBV5QG1QwvSsypBZ6r9mqg/3kt5ZygtV4Dj5KV+NkZ+cTFun2OqkjPxrp6gFfxDpF96y9VMPuon5RstcgciBEL3wPA/hD+L0RuJb3mTR7K5USCRz4KLMzz+baXqJWcPO1ol8c4JPeuIl/qMq1FRBJMDgpLzTTvQ2omy8KhpQRzeIWtdXVYJoMNhlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=byyWW5EjJ5JP8YAPUP7I3603V15sHg9WrQ0YJy3sn4U=; b=IiSSPAWB48+TmXIjo2U9oFrbftg8O2jlkI9vV8NXWb/kdOhYu3TCRrTvTnx3AO+uUPQviFG08J/uogjQCKinkxpQm0UQIP6jm04VSZWuzf4RIlEYqqmlWueyoCQkpMriJXDumNNGhLR/4nzTL/q764OCLKYqsD6H2aV3qL3uEyEsk7OUgMAxwLzj17KjyjNhTGZ0LGgUIeo0p6+BenxG1fnAGBITiDxHCxFvCVHyjWd/VKu2IXA4f0gjLuYKYZYnyxQly8vPJjUelPiNNDOKxxAM1MyDgPtdDuu5evWQQ+oTIEIkR/RCrgmhvJwoyrtloRUqKakRL4TjX5MPhKmxdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector2-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=byyWW5EjJ5JP8YAPUP7I3603V15sHg9WrQ0YJy3sn4U=; b=EEQkoRcooeQLD+UfLwJtZcLdgGKaVuiDJK+Sq74qnxWO8DDRDSY//RJ16Lih12Uqp0iuurKxGIp6QBcYgsK2irlefJ6/G7ab48QWZFnzZLBrPyrIgFbxQ/MTrrOpVkry9lcQ70VW+qujyVvIwvs0rrQG7dEsIFoCMc1/S7/9Nqw= Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=fb.com; Received: from BYAPR15MB4136.namprd15.prod.outlook.com (2603:10b6:a03:96::24) by BYAPR15MB3159.namprd15.prod.outlook.com (2603:10b6:a03:101::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21; Wed, 6 Jan 2021 20:04:45 +0000 Received: from BYAPR15MB4136.namprd15.prod.outlook.com ([fe80::780c:8570:cb1d:dd8c]) by BYAPR15MB4136.namprd15.prod.outlook.com ([fe80::780c:8570:cb1d:dd8c%6]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 20:04:45 +0000 Date: Wed, 6 Jan 2021 12:04:40 -0800 From: Roman Gushchin To: Andrew Morton CC: , Michal Hocko , Johannes Weiner , Shakeel Butt , , , Imran Khan Subject: Re: [PATCH] mm: memcg/slab: optimize objcg stock draining Message-ID: <20210106200440.GC1110904@carbon.dhcp.thefacebook.com> References: <20210106042239.2860107-1-guro@fb.com> <20210106115044.c4393afa1ad61ef3f8db1d94@linux-foundation.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106115044.c4393afa1ad61ef3f8db1d94@linux-foundation.org> X-Originating-IP: [2620:10d:c090:400::5:e8fe] X-ClientProxiedBy: CO1PR15CA0068.namprd15.prod.outlook.com (2603:10b6:101:20::12) To BYAPR15MB4136.namprd15.prod.outlook.com (2603:10b6:a03:96::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:e8fe) by CO1PR15CA0068.namprd15.prod.outlook.com (2603:10b6:101:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Wed, 6 Jan 2021 20:04:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b353ebb-6dd2-4033-32bb-08d8b27e5005 X-MS-TrafficTypeDiagnostic: BYAPR15MB3159: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-FB-Source: Internal X-MS-Oob-TLC-OOBClassifiers: OLM:883; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IWdeu2NXWL9zgGduuTe+NX7x3Uo0bsGVGqLYqmtsyMaTk0CED8pjxfOH+EinCHtedXkVeEyyTie4pbIg6MmBFsurDrPYTUx+F1P57Q8Np519fUOa/iRY+EqDLnPRArUPLUwMYeoxF+k+v31HtxwPRo7U8TvIqk9VV4DfSg5qvYyc8Mm9+Y69cNEkSV3IpXmPwGMpE+NkgJ9Pyjsk9+4GVKrfPKPy0RKI+PQwMLVdgxEHGHsWoZWGQ6Btsmj351n7pP21Pv4JMJ9CYvfr12GkcslRLOQNP1TDjyiJOhQfXgPe7zgKAa2OAI0pFwUqXDgwF2HCEU2zaQWG6YRzLpYvHOufgm7W9UYcDsG/wxFyWW86Ji3r6GqK8A8ay9TKMn7Tk3erDi1ucMMd4B7pAdtfNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(396003)(136003)(366004)(346002)(54906003)(9686003)(4744005)(52116002)(4326008)(8936002)(7696005)(316002)(55016002)(478600001)(33656002)(5660300002)(1076003)(83380400001)(6916009)(6506007)(66946007)(186003)(16526019)(66476007)(66556008)(8676002)(2906002)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?PSGrpqEPIukLAyo357U0F9aX0wTlpQiQBT3hiQimIA1KQYFKrYNHWllbQ9nd?= =?us-ascii?Q?tSQsd6dNlMbq+8AHeEMdvhlDRJHL/yuXZUxwHcfB0ojDiLdqrHhaUBW9oBBb?= =?us-ascii?Q?+Nr+Pd/R6wjG3hxxgGmWSfXkSURCd6niotYUHpaG4eMmBsJ7A4o9/nUYAVHe?= =?us-ascii?Q?UCOYZmq7+Q9dSSVlSKiBMVrO0DFIfcxiTGpoKpPVKE3XCPMKzjL2BJ6X3igY?= =?us-ascii?Q?NZW+5mMfpLr9idYp3t1pvW826Ye3aJ0tt9iW0o0Fut60iIkIXD1bLGHve1qW?= =?us-ascii?Q?HPJGx5I7jxJDL/aOvI2DtacXB04OAat701rAMTvSzqokZUVWB0WMnw3uTCj0?= =?us-ascii?Q?ioMxyN2g1pUhkBa7umhKyAx5T9rzbHGr4vTVcY1F/uZzV1zqSMPLJvSNOVyG?= =?us-ascii?Q?quwkJUyuYn4ZPGqfIHmMEkDFnUFBkD+eFe3oeUZY0lYXLwJNbCAHx4Z64G+e?= =?us-ascii?Q?EgPunzaB+OBxCwt4relyltpuJzWIAnhhysBhy9KySs2koNzns7a+1BMJhzNb?= =?us-ascii?Q?S5OW+lvTX1w8eMNWrzTali5idaKqLF/GzLszzUPaU3QLhzQYmQELEC2ZnFmG?= =?us-ascii?Q?5ftVscYNaREVA2u3tD9jSVDm8YJmHwmmUNIfXxu/iPALRoxgNA0Vfe3PgVMc?= =?us-ascii?Q?2dkpaiToT9G8PvRqJJdhPVMw8x63bGksxgpezCtk2Gqr6l+CFF6h8noNPdFy?= =?us-ascii?Q?O7ku1C4Xf/mlD0+YrrHRhVrctxP1Vx/7pTcdJiMHNVuSzuMSIcXJvPqHmlI5?= =?us-ascii?Q?jZ9yO68DYloLGPsfj5doMXu9xs1sSNvlfgnh0aRl7A9Wz2wpKPFGEKEtkgNo?= =?us-ascii?Q?8fI4/LYsSGhYLDOCnXCHHOz4PY9ytSkkFz6dJws2lKt71HpECU5L+wsxBsav?= =?us-ascii?Q?UviHLtBhIYAggUopC/SJE6lKNEK/IAp1mUpplu00ztQ/zYVx5zsnzsqqHbE1?= =?us-ascii?Q?EYkYWD9KArGzTyhAAjfm7s2bpfyjdSbWBEgJbkv57y+7ULPWC8tovQb+TEV1?= =?us-ascii?Q?amwnGRp6/dEXM5+qpX/QjFAbcw=3D=3D?= X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2021 20:04:45.0326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-Network-Message-Id: 0b353ebb-6dd2-4033-32bb-08d8b27e5005 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KpKvpiifjS7kEjdznvmG6uXEZKLqZJ9pTUKYbv4sjao7zo+rB8hj1AJyAcGR88su X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3159 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-06_11:2021-01-06,2021-01-06 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 suspectscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 phishscore=0 spamscore=0 mlxlogscore=639 malwarescore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060113 X-FB-Internal: deliver X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 06, 2021 at 11:50:44AM -0800, Andrew Morton wrote: > On Tue, 5 Jan 2021 20:22:39 -0800 Roman Gushchin wrote: > > > Imran Khan reported a regression in hackbench results caused by the > > commit f2fe7b09a52b ("mm: memcg/slab: charge individual slab objects > > instead of pages"). > > How large was the regression? ~16% according to Imran's data. > > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -3122,9 +3122,7 @@ void __memcg_kmem_uncharge(struct mem_cgroup *memcg, unsigned int nr_pages) > > if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > > page_counter_uncharge(&memcg->kmem, nr_pages); > > > > - page_counter_uncharge(&memcg->memory, nr_pages); > > - if (do_memsw_account()) > > - page_counter_uncharge(&memcg->memsw, nr_pages); > > + refill_stock(memcg, nr_pages); > > } > > IOW, which kernel version(s) should we be patching? 5.9+ Thanks!