From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F52C433E0 for ; Wed, 6 Jan 2021 19:50:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22D6023132 for ; Wed, 6 Jan 2021 19:50:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22D6023132 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 730076B02C8; Wed, 6 Jan 2021 14:50:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7073F6B02CA; Wed, 6 Jan 2021 14:50:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61C9C6B02CB; Wed, 6 Jan 2021 14:50:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 4C1C76B02C8 for ; Wed, 6 Jan 2021 14:50:47 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0F35C180AD811 for ; Wed, 6 Jan 2021 19:50:47 +0000 (UTC) X-FDA: 77676392934.04.brain49_050060c274e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id EA25D8011453 for ; Wed, 6 Jan 2021 19:50:46 +0000 (UTC) X-HE-Tag: brain49_050060c274e4 X-Filterd-Recvd-Size: 2214 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 19:50:46 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EFDE923131; Wed, 6 Jan 2021 19:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1609962645; bh=5kwh7EXq15V7c3k8dlsJ1An7qOaZRPcY0YlVfb4e0Q4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JlGRz55g7P3lJhKFgyXyXXHFWrlDGKKgiuVL75F6D5V0NJzNdck+Et37fd4VgVXgp /O+/fLAKYtYzd431NRrGH3/4gkfZAFNouEwd8R+D0Bmvwc3OdAY5O5DsfLNNH6l0Qt GCxq0Oh60XK9iDCK0baAm3nIF5YVYJyroAyQGk9Q= Date: Wed, 6 Jan 2021 11:50:44 -0800 From: Andrew Morton To: Roman Gushchin Cc: , Michal Hocko , Johannes Weiner , Shakeel Butt , , , Imran Khan Subject: Re: [PATCH] mm: memcg/slab: optimize objcg stock draining Message-Id: <20210106115044.c4393afa1ad61ef3f8db1d94@linux-foundation.org> In-Reply-To: <20210106042239.2860107-1-guro@fb.com> References: <20210106042239.2860107-1-guro@fb.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 5 Jan 2021 20:22:39 -0800 Roman Gushchin wrote: > Imran Khan reported a regression in hackbench results caused by the > commit f2fe7b09a52b ("mm: memcg/slab: charge individual slab objects > instead of pages"). How large was the regression? > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3122,9 +3122,7 @@ void __memcg_kmem_uncharge(struct mem_cgroup *memcg, unsigned int nr_pages) > if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > page_counter_uncharge(&memcg->kmem, nr_pages); > > - page_counter_uncharge(&memcg->memory, nr_pages); > - if (do_memsw_account()) > - page_counter_uncharge(&memcg->memsw, nr_pages); > + refill_stock(memcg, nr_pages); > } IOW, which kernel version(s) should we be patching?