From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A15FC433DB for ; Wed, 6 Jan 2021 19:33:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7876E2312F for ; Wed, 6 Jan 2021 19:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7876E2312F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A96F26B02C3; Wed, 6 Jan 2021 14:33:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A474E6B02C4; Wed, 6 Jan 2021 14:33:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90F926B02C5; Wed, 6 Jan 2021 14:33:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 7AB296B02C3 for ; Wed, 6 Jan 2021 14:33:07 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 30DB8180AD806 for ; Wed, 6 Jan 2021 19:33:07 +0000 (UTC) X-FDA: 77676348414.30.rule65_0f0fe4f274e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id C059F180B3C83 for ; Wed, 6 Jan 2021 19:33:06 +0000 (UTC) X-HE-Tag: rule65_0f0fe4f274e4 X-Filterd-Recvd-Size: 2315 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 19:33:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CDE392312C; Wed, 6 Jan 2021 19:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1609961585; bh=660NBkaEC1hJB/mFkMWFSGgp4y+beSOalMN9oPgqXHM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fcBi4bWK+4+gt9XJbwxUO0gNGKlj4eux8unZWWusjpR501jIFHD6/jzmdrN/zsgg2 LXeDSi+SEtRDsaHWW6uvdPZcegfECJrcDQEQJ7b9REDWxSly4saXF0ENqV0PAn+9dN Qkd3KthLSgjWEMvS0K2WEBq3Pm9FPtQSgx2zO7u0= Date: Wed, 6 Jan 2021 11:33:04 -0800 From: Andrew Morton To: Baoquan He Cc: Hugh Dickins , Hui Su , Alex Shi , Lorenzo Stoakes , Michal Hocko , Johannes Weiner , Shakeel Butt , Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec() Message-Id: <20210106113304.e74683a0e1b8639e930b21f6@linux-foundation.org> In-Reply-To: <20210106064935.GA3338@MiWiFi-R3L-srv> References: <20210106064935.GA3338@MiWiFi-R3L-srv> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > --- 5.11-rc2/include/linux/memcontrol.h 2020-12-27 20:39:36.751923135 -0800 > > +++ linux/include/linux/memcontrol.h 2021-01-03 19:38:24.822978559 -0800 > > @@ -665,7 +665,7 @@ static inline struct lruvec *mem_cgroup_ > > { > > struct mem_cgroup *memcg = page_memcg(page); > > > > - VM_WARN_ON_ONCE_PAGE(!memcg, page); > > + VM_WARN_ON_ONCE_PAGE(!memcg && !mem_cgroup_disabled(), page); > > return mem_cgroup_lruvec(memcg, pgdat); > > Thanks for fixing this. We also encountered this issue in kdump kernel > with the mainline 5.10 kernel since 'cgroup_disable=memory' is added. Thanks - I added the cc:stable.