From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: Hugh Dickins <hughd@google.com>, Hui Su <sh_def@163.com>,
Alex Shi <alex.shi@linux.alibaba.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>, Roman Gushchin <guro@fb.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()
Date: Wed, 6 Jan 2021 11:33:04 -0800 [thread overview]
Message-ID: <20210106113304.e74683a0e1b8639e930b21f6@linux-foundation.org> (raw)
In-Reply-To: <20210106064935.GA3338@MiWiFi-R3L-srv>
On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He <bhe@redhat.com> wrote:
> > --- 5.11-rc2/include/linux/memcontrol.h 2020-12-27 20:39:36.751923135 -0800
> > +++ linux/include/linux/memcontrol.h 2021-01-03 19:38:24.822978559 -0800
> > @@ -665,7 +665,7 @@ static inline struct lruvec *mem_cgroup_
> > {
> > struct mem_cgroup *memcg = page_memcg(page);
> >
> > - VM_WARN_ON_ONCE_PAGE(!memcg, page);
> > + VM_WARN_ON_ONCE_PAGE(!memcg && !mem_cgroup_disabled(), page);
> > return mem_cgroup_lruvec(memcg, pgdat);
>
> Thanks for fixing this. We also encountered this issue in kdump kernel
> with the mainline 5.10 kernel since 'cgroup_disable=memory' is added.
Thanks - I added the cc:stable.
next prev parent reply other threads:[~2021-01-06 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 5:03 Hugh Dickins
2021-01-04 8:11 ` Alex Shi
2021-01-06 6:49 ` Baoquan He
2021-01-06 19:33 ` Andrew Morton [this message]
2021-01-06 19:35 ` Andrew Morton
2021-01-07 2:53 ` Baoquan He
2021-01-06 16:19 ` Chris Down
2021-01-07 18:04 ` Vlastimil Babka
2021-01-09 2:23 ` Hugh Dickins
[not found] <alpine.LSU.2.11.2101032107230.1158@eggly.anvils>
2021-01-04 18:09 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106113304.e74683a0e1b8639e930b21f6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=bhe@redhat.com \
--cc=guro@fb.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@suse.com \
--cc=sh_def@163.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox