From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DC2C433E0 for ; Wed, 6 Jan 2021 03:47:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3DDE522D04 for ; Wed, 6 Jan 2021 03:47:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DDE522D04 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C11A48D00E0; Tue, 5 Jan 2021 22:47:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE92B8D00D1; Tue, 5 Jan 2021 22:47:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD99D8D00E0; Tue, 5 Jan 2021 22:47:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 99AB68D00D1 for ; Tue, 5 Jan 2021 22:47:24 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5F407824556B for ; Wed, 6 Jan 2021 03:47:24 +0000 (UTC) X-FDA: 77673965208.25.hands39_36027f2274de Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 3BD2C1804E3A0 for ; Wed, 6 Jan 2021 03:47:24 +0000 (UTC) X-HE-Tag: hands39_36027f2274de X-Filterd-Recvd-Size: 6761 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 03:47:22 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id 4so886074plk.5 for ; Tue, 05 Jan 2021 19:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:mail-followup-to:mime-version :content-disposition:user-agent; bh=vJphBylUyfRBLd0KjwNu7dzrYLKUuRAIjJORmt8gKFM=; b=UADAf0v+riuXRh8QHcdOF92aLenvoNDIgspIEIhT0lmhAdhCE0imRB41B/rwuveGDX zFK4V8lOcHkFVg1ZlCAmAbAqkSI2nJ3BDOnLHiuiIQOWOOwDfECZB8OuILZPlB/t82nO Suzt75PVVGc61Byu+CU804jeS7X1YZPQxb5IxHxvIEuwT03XoX+1+FG4paLg8ZzoTk8r zXBErIbkxOi4Screg7dNZqRY1hwFxtH0O9FpVaInNMx4Rf4Igtkl7PueeLGRw7UNSzjO ehvruNgslMrnYBRpBvQi77sde6oLdOWWypyqFS98EPKz/hW0Pxd5YzIUkuQJfSfSccJr I6dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id :mail-followup-to:mime-version:content-disposition:user-agent; bh=vJphBylUyfRBLd0KjwNu7dzrYLKUuRAIjJORmt8gKFM=; b=PTdSWtJO/4AbhMOEbHaA4m3qf2VjziBXdSFSxBVJ+UFjgu751fKUEQVM1wRWGbRal7 39LojwfeXeRpxA775+R/UCYkv6JJcKShdH0OcRd+5Uqhach119p0YtorDP91mNZkgkfS 58sMUcpX7u8RF0JePS+4nyFR+o1g727ix0iXwVvP8DTEhAHhbxu578Z1sLxuyZb1NA7E 51KKRqfh9oefQSXPg/CwAA38i2hh/p2x+cvUkrnFjFJsru383dIZ0tsvmHd5pVlhAvIG dIbgyBELJ6riWJkZqq7uY2S7JiyW+zPlllTbDIwLpkjf5Hrl2oqPEbegurY+vWNeuzom Ta4w== X-Gm-Message-State: AOAM530hBvWIewV8S1HN1uRF1H0vRpQcJ9fS80WgyiQs9fDjE2lJfoDx 9Bfe5F7oDy1UTKaveD/LCkg= X-Google-Smtp-Source: ABdhPJyjcEoTJ7mKcLsx8+M6xfjkpI283KIp57+hZihzR132LBI0Yxy5O1+DCbl3qaZocHq7pmhERg== X-Received: by 2002:a17:902:bf44:b029:da:d140:6f91 with SMTP id u4-20020a170902bf44b02900dad1406f91mr2260025pls.51.1609904842148; Tue, 05 Jan 2021 19:47:22 -0800 (PST) Received: from open-light-1.localdomain (66.98.113.28.16clouds.com. [66.98.113.28]) by smtp.gmail.com with ESMTPSA id 19sm726179pfu.85.2021.01.05.19.47.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jan 2021 19:47:21 -0800 (PST) From: Liang Li X-Google-Original-From: Liang Li Date: Tue, 5 Jan 2021 22:47:18 -0500 To: Alexander Duyck , Mel Gorman , Andrew Morton , Andrea Arcangeli , Dan Williams , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Dave Hansen , Michal Hocko , Liang Li , Liang Li , Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH 1/6] mm: Add batch size for free page reporting Message-ID: <20210106034715.GA1138@open-light-1.localdomain> Mail-Followup-To: Alexander Duyck , Mel Gorman , Andrew Morton , Andrea Arcangeli , Dan Williams , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Dave Hansen , Michal Hocko , Liang Li , Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use the page order as the only threshold for page reporting is not flexible and has some flaws. Because scan a long free list is not cheap, it's better to wake up the page reporting worker when there are more pages, wake it up for a sigle page may not worth. This patch add a batch size as another threshold to control the waking up of reporting worker. Cc: Alexander Duyck Cc: Mel Gorman Cc: Andrea Arcangeli Cc: Dan Williams Cc: Dave Hansen Cc: David Hildenbrand Cc: Michal Hocko Cc: Andrew Morton Cc: Alex Williamson Cc: Michael S. Tsirkin Cc: Liang Li Signed-off-by: Liang Li --- mm/page_reporting.c | 1 + mm/page_reporting.h | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/mm/page_reporting.c b/mm/page_reporting.c index cd8e13d41df4..694df981ddd2 100644 --- a/mm/page_reporting.c +++ b/mm/page_reporting.c @@ -12,6 +12,7 @@ #define PAGE_REPORTING_DELAY (2 * HZ) static struct page_reporting_dev_info __rcu *pr_dev_info __read_mostly; +unsigned long page_report_batch_size __read_mostly = 16 * 1024 * 1024UL; enum { PAGE_REPORTING_IDLE = 0, diff --git a/mm/page_reporting.h b/mm/page_reporting.h index 2c385dd4ddbd..b8fb3bbb345f 100644 --- a/mm/page_reporting.h +++ b/mm/page_reporting.h @@ -12,6 +12,8 @@ #define PAGE_REPORTING_MIN_ORDER pageblock_order +extern unsigned long page_report_batch_size; + #ifdef CONFIG_PAGE_REPORTING DECLARE_STATIC_KEY_FALSE(page_reporting_enabled); void __page_reporting_notify(void); @@ -33,6 +35,8 @@ static inline bool page_reported(struct page *page) */ static inline void page_reporting_notify_free(unsigned int order) { + static long batch_size; + /* Called from hot path in __free_one_page() */ if (!static_branch_unlikely(&page_reporting_enabled)) return; @@ -41,8 +45,12 @@ static inline void page_reporting_notify_free(unsigned int order) if (order < PAGE_REPORTING_MIN_ORDER) return; - /* This will add a few cycles, but should be called infrequently */ - __page_reporting_notify(); + batch_size += (1 << order) << PAGE_SHIFT; + if (batch_size >= page_report_batch_size) { + batch_size = 0; + /* This add a few cycles, but should be called infrequently */ + __page_reporting_notify(); + } } #else /* CONFIG_PAGE_REPORTING */ #define page_reported(_page) false -- 2.18.2