From: Sebastian Reichel <sre@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: akpm@linux-foundation.org, broonie@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Timon Baetz <timon.baetz@protonmail.com>
Subject: Re: mmotm 2021-01-04-16-56 uploaded (drivers/power/supply/max8997_charger.c)
Date: Tue, 5 Jan 2021 15:04:04 +0100 [thread overview]
Message-ID: <20210105140404.plxeasjxipvqrehl@earth.universe> (raw)
In-Reply-To: <6ed164be-e80e-e69f-c164-4e1c68465728@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]
Hi Randy,
On Mon, Jan 04, 2021 at 08:26:04PM -0800, Randy Dunlap wrote:
> Commit bb118e5178b3 in linux-next seems to introduce a few build problems:
>
> ld: drivers/power/supply/max8997_charger.o: in function `max8997_battery_extcon_evt_worker':
> max8997_charger.c:(.text+0xa3): undefined reference to `extcon_get_state'
> ld: max8997_charger.c:(.text+0x102): undefined reference to `extcon_get_state'
> ld: max8997_charger.c:(.text+0x161): undefined reference to `extcon_get_state'
> ld: max8997_charger.c:(.text+0x1c0): undefined reference to `extcon_get_state'
> ld: max8997_charger.c:(.text+0x21f): undefined reference to `extcon_get_state'
> ld: drivers/power/supply/max8997_charger.o: in function `max8997_battery_probe':
> max8997_charger.c:(.text+0x962): undefined reference to `extcon_get_edev_by_phandle'
> ld: max8997_charger.c:(.text+0xab0): undefined reference to `devm_extcon_register_notifier_all'
>
>
> CONFIG_EXTCON=m
> CONFIG_CHARGER_MAX8997=y
>
>
> Full randconfig file is attached.
Thanks for the report, I just force pushed an update for bb118e5178b3
("power: supply: max8997_charger: Set CHARGER current limit"), which
adds 'depends on EXTCON || !EXTCON' to config CHARGER_MAX8997 into
power-supply's for-next branch.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-01-05 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 0:57 mmotm 2021-01-04-16-56 uploaded akpm
2021-01-05 4:26 ` mmotm 2021-01-04-16-56 uploaded (drivers/power/supply/max8997_charger.c) Randy Dunlap
2021-01-05 14:04 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105140404.plxeasjxipvqrehl@earth.universe \
--to=sre@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=timon.baetz@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox