From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hui Su <sh_def@163.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm/page_alloc: remove the static for local variable node_order
Date: Tue, 5 Jan 2021 01:30:26 +0000 [thread overview]
Message-ID: <20210105013026.GA175893@casper.infradead.org> (raw)
In-Reply-To: <20210104152357.d56d10e0443bae984a174f18@linux-foundation.org>
On Mon, Jan 04, 2021 at 03:23:57PM -0800, Andrew Morton wrote:
> On Wed, 30 Dec 2020 12:42:33 +0000 Matthew Wilcox <willy@infradead.org> wrote:
>
> > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > > local variable node_order do not need the static here.
> >
> > It bloody well does. It can be up to 2^10 entries on x86 (and larger
> > on others) That's 4kB which you've now moved onto the stack.
>
> That being said, could we kmalloc the scratch area in
> __build_all_zonelists()? And maybe remove that static spinlock?
>
> (what blocks node and cpu hotplug in there??)
if we don't have the zonelists built yet, can slab possibly be operational?
next prev parent reply other threads:[~2021-01-05 1:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 11:40 Hui Su
2020-12-30 12:42 ` Matthew Wilcox
2020-12-30 12:59 ` Hui Su
2020-12-30 13:41 ` Muchun Song
2021-01-04 8:47 ` Michal Hocko
2021-01-04 23:23 ` Andrew Morton
2021-01-05 1:30 ` Matthew Wilcox [this message]
2021-01-05 7:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105013026.GA175893@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox