From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223BDC433DB for ; Mon, 4 Jan 2021 22:36:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B37BC2253A for ; Mon, 4 Jan 2021 22:36:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B37BC2253A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03C778D0032; Mon, 4 Jan 2021 17:36:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2DA78D002D; Mon, 4 Jan 2021 17:36:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1C828D0032; Mon, 4 Jan 2021 17:36:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id C94878D002D for ; Mon, 4 Jan 2021 17:36:37 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 92DFC180AD811 for ; Mon, 4 Jan 2021 22:36:37 +0000 (UTC) X-FDA: 77669553234.18.quiet33_421646d274d3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 6F909100ED0FC for ; Mon, 4 Jan 2021 22:36:37 +0000 (UTC) X-HE-Tag: quiet33_421646d274d3 X-Filterd-Recvd-Size: 4945 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Jan 2021 22:36:36 +0000 (UTC) Received: by mail-qv1-f46.google.com with SMTP id a4so13813818qvd.12 for ; Mon, 04 Jan 2021 14:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7vAfgGhGy3ZASCGh1dtgdS9kLlepR0AtWowcM6gy574=; b=r5VJryTB7PQuBJEhYTa/NxNNzPQB6QKUEmSYB6A1QxfENBP/UjehLl+7U6FdMkL5zp SO7VV6QNbkIINMAY9WYnL6ybC5HeWuZ0uJh1P8wN9aD4mKaCuex0CbZv1RYgrcnNib8z alxdqQsC7lvcUrDdVpp2oLrycKHubePozNkH21mNbfgQgp8xrkHm9TShu9EEZ9u82YOF UpHJ9LW0uTXPYi1At/5vcU2GdhESjAbpSm/RLcrLrGVGtJXEOOzjzqIFgfWLXRsMnEYl dzj4wWdAQCZ0TBnASGolT6u00eMtJNIRCDDzUir36eH2NB/9BO9HArUx8w4wbsDq9P8G 6jXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7vAfgGhGy3ZASCGh1dtgdS9kLlepR0AtWowcM6gy574=; b=MtU1mCtX/vOO+sp+TbB+VhFRfHLPf2thbmO2JQ9uOBJXY6W9bVW4fPhZNLZuads6jq w72v4CHoqEe/0zY3n/3GhrCSPcbpczjyB5EeQ/6kAUpHXVDOICClhX8As28u3Tos8vgX 5km2ueEHf35wzIbCIoueU7WZii2C+P0iXnocUH/V+277Gg+4h1ncytGAVhu038dB5L56 tiRmMHQx0MOVzsSl2SU8fheBC2Qk8Sm53BajNCRpu/1zWRr7LwkHk4fCxdUSB9TzaBek BTCcYHTJ1CeXE09y5TXk5b57Y2QlX5mYpEkbQvcTme5PdG6NOgbkAKDxUYBr8t6czfRI HUoA== X-Gm-Message-State: AOAM533SThzxRG5Vuzt+nHxzYaEQgbf7zhVCBYjxIb1TYjY7NVwk6uY8 ib1GB6Zsg4bpBXHnJlRRTUc= X-Google-Smtp-Source: ABdhPJyIclj68K5QfxqicR04obaRI1e5dSn9+H+B81tPmNDCZLG0WiK1wFXmmWQkAeogXjp98+pZNA== X-Received: by 2002:a0c:b64e:: with SMTP id q14mr53155701qvf.52.1609799796403; Mon, 04 Jan 2021 14:36:36 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id n66sm38105504qkn.136.2021.01.04.14.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 14:36:35 -0800 (PST) Date: Mon, 4 Jan 2021 15:36:34 -0700 From: Nathan Chancellor To: Arnd Bergmann Cc: Andrew Morton , Nick Desaulniers , "Kirill A. Shutemov" , Wei Yang , Arnd Bergmann , Vlastimil Babka , Dmitry Safonov <0x7f454c46@gmail.com>, Brian Geffon , linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent Message-ID: <20210104223634.GB2562866@ubuntu-m3-large-x86> References: <20201230154104.522605-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230154104.522605-1-arnd@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 30, 2020 at 04:40:40PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang cannt evaluate this function argument at compile time > when the function is not inlined, which leads to a link > time failure: > > ld.lld: error: undefined symbol: __compiletime_assert_414 > >>> referenced by mremap.c > >>> mremap.o:(get_extent) in archive mm/built-in.a > > Mark the function as __always_inline to avoid it. > > Fixes: 9ad9718bfa41 ("mm/mremap: calculate extent in one place") > Signed-off-by: Arnd Bergmann > --- > mm/mremap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/mremap.c b/mm/mremap.c > index c5590afe7165..1cb464a07184 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -336,8 +336,9 @@ enum pgt_entry { > * valid. Else returns a smaller extent bounded by the end of the source and > * destination pgt_entry. > */ > -static unsigned long get_extent(enum pgt_entry entry, unsigned long old_addr, > - unsigned long old_end, unsigned long new_addr) > +static __always_inline unsigned long get_extent(enum pgt_entry entry, > + unsigned long old_addr, unsigned long old_end, > + unsigned long new_addr) > { > unsigned long next, extent, mask, size; > > -- > 2.29.2 > I am in agreement with Vlastimil, I would rather see the BUILD_BUG() dropped or converted into BUG() instead of papering over with __always_inline. For what it's worth, I only see this build failure with CONFIG_UBSAN_UNSIGNED_OVERFLOW, which you proposed disabling: https://lore.kernel.org/lkml/20201230154749.746641-1-arnd@kernel.org/ Cheers, Nathan