From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B708C433E0 for ; Mon, 4 Jan 2021 07:01:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 30F2E21D79 for ; Mon, 4 Jan 2021 07:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30F2E21D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7AE816B00A3; Mon, 4 Jan 2021 02:01:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75F938D0002; Mon, 4 Jan 2021 02:01:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650178D0001; Mon, 4 Jan 2021 02:01:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 4D3586B00A3 for ; Mon, 4 Jan 2021 02:01:38 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 11649180AD80F for ; Mon, 4 Jan 2021 07:01:38 +0000 (UTC) X-FDA: 77667197076.15.coach80_3301e63274ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id E14271814B0C1 for ; Mon, 4 Jan 2021 07:01:37 +0000 (UTC) X-HE-Tag: coach80_3301e63274ce X-Filterd-Recvd-Size: 4235 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Jan 2021 07:01:37 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id g15so18444689pgu.9 for ; Sun, 03 Jan 2021 23:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s/SmIjUY1iXgmpYVoTEFRvKyqR5z81Ow+60craOQ1V8=; b=eX/7BvY+k8Ogg2yVzYJp4S1E7wxS+1ns6iztHR1qdNGA0tGUFYHIX6VbfvCb80bFFn cP54FoMdobERR5RY7H6uMyhUl/qW0RHUbRWsgVXjR/iPwtz348CFIea3xrDoRVa2lFuc kDESclSiyB99S7MiaC7PePmiBzmZdrH9o4O/S3+gaQ4KIk9aoqO17qIDhxc4aMfw7Zuz 3+s+aNHffdQo8PERgbFflMQKiUBCjT3JT7XrhVg1hrxJ3oyvmWh2lDM9pOe+mTLxwQ+G T97FRiYo4p/m0IRbeMzD0XRUSXXQ7tQP5zYNdwpDpFTFKc2vhhu5ISpqPvWaZOxsjdDS d7bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s/SmIjUY1iXgmpYVoTEFRvKyqR5z81Ow+60craOQ1V8=; b=mMl3z1erf7merooLngodYYa3dZxBI0SYDxj8DzcBe3Uwxm0Nx82MME/SrvAn3Tdofk AEOXbgkYRVxP5Dg1rDuF7CRZU674oU8US/7pOQnCMl8Gz6CJ/VnFFFezVWjreprXQqos svNBE6P+H7DnMIC6A7erMQLTyAF7lGbXJP2ZPcMOHJY2UQmu6Qd04/IS9SojmMgNXaJV 4iLv+M3ElgpwAUZmqsMOfvERTbTNh5cOJVjHyFLyZwVT9szhx2f+5XDb29OcapSBp+XN UJZxQE23S/7u07dtjaM5vJ3ippwmpnVeqaQnv5SIEYIE0u5X1lN1GLDcGWTtJ4oPj6ZB NmXw== X-Gm-Message-State: AOAM5309YTbaO92PUrW23M/EZFquo51pl5UtQLT22lYoM8nNDopzVLdp jODtl3dS/ZUuS0yLApHfD+uzow== X-Google-Smtp-Source: ABdhPJwY5jsG9Aek0pLNoLlUr8MTESblTrmvgVjTEfEY1zFB3mN+RiZLmSk00JPfpWzizO3Zi3ocQw== X-Received: by 2002:a05:6a00:1481:b029:197:fc39:f646 with SMTP id v1-20020a056a001481b0290197fc39f646mr44458467pfu.57.1609743696095; Sun, 03 Jan 2021 23:01:36 -0800 (PST) Received: from localhost.localdomain ([240e:b1:e401:3::6]) by smtp.gmail.com with ESMTPSA id v1sm36306648pga.63.2021.01.03.23.01.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2021 23:01:35 -0800 (PST) From: Muchun Song To: mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: hillf.zj@alibaba-inc.com, n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, yongjun_wei@trendmicro.com.cn, mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page Date: Mon, 4 Jan 2021 14:58:39 +0800 Message-Id: <20210104065843.5658-2-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210104065843.5658-1-songmuchun@bytedance.com> References: <20210104065843.5658-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Because we only can isolate a active page via isolate_huge_page() and hugetlbfs_fallocate() forget to mark it as active, we cannot isolate and migrate those pages. Fixes: 70c3547e36f5 (hugetlbfs: add hugetlbfs_fallocate()) Signed-off-by: Muchun Song --- fs/hugetlbfs/inode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index b5c109703daa..2aceb085d202 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -737,10 +737,11 @@ static long hugetlbfs_fallocate(struct file *file, = int mode, loff_t offset, =20 /* * unlock_page because locked by add_to_page_cache() - * page_put due to reference from alloc_huge_page() + * put_page() (which is in the putback_active_hugepage()) + * due to reference from alloc_huge_page() */ unlock_page(page); - put_page(page); + putback_active_hugepage(page); } =20 if (!(mode & FALLOC_FL_KEEP_SIZE) && offset + len > inode->i_size) --=20 2.11.0