From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFCB6C433E0 for ; Wed, 30 Dec 2020 13:01:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 53ED12220B for ; Wed, 30 Dec 2020 13:01:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53ED12220B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 488E28D0085; Wed, 30 Dec 2020 08:01:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 439338D007F; Wed, 30 Dec 2020 08:01:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34EF98D0085; Wed, 30 Dec 2020 08:01:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 1B58D8D007F for ; Wed, 30 Dec 2020 08:01:00 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D44ED8249980 for ; Wed, 30 Dec 2020 13:00:59 +0000 (UTC) X-FDA: 77649958638.06.mint65_2b0ad19274a5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 9E9DE10046DA8 for ; Wed, 30 Dec 2020 13:00:59 +0000 (UTC) X-HE-Tag: mint65_2b0ad19274a5 X-Filterd-Recvd-Size: 2277 Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Dec 2020 13:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=Vq/jt T4DcwIkqvSQv+fIEjUupKGdKzlR1CmJFed2Syo=; b=dus3OHVjPMKoZKgllID3Z fxasKX1pKSRoGYwKpWAhT7HnKT8djuiVdHLxgZCFqS3YoozF/f/51Vlr9kYB2kCY LuZTlnpvIjAEfOOZTj87lcCGQoenMs2mBRFvD1vrHV74nIaPqtCVk4i2upBXJ+2O Ubum3yz3MQcXosgOxPCQ6M= Received: from localhost (unknown [101.86.213.121]) by smtp8 (Coremail) with SMTP id DMCowACHENzAeexf9qzHJg--.23498S2; Wed, 30 Dec 2020 20:59:45 +0800 (CST) Date: Wed, 30 Dec 2020 20:59:44 +0800 From: Hui Su To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH] mm/page_alloc: remove the static for local variable node_order Message-ID: <20201230125944.GA2040977@ubuntu-A520I-AC> References: <20201230114014.GA1934427@ubuntu-A520I-AC> <20201230124233.GE28221@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230124233.GE28221@casper.infradead.org> X-CM-TRANSID:DMCowACHENzAeexf9qzHJg--.23498S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUc4lkUUUUU X-Originating-IP: [101.86.213.121] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiIAELX10TCy4s7QAAsf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Matthew: On Wed, Dec 30, 2020 at 12:42:33PM +0000, Matthew Wilcox wrote: > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > > local variable node_order do not need the static here. > > It bloody well does. It can be up to 2^10 entries on x86 (and larger > on others) That's 4kB which you've now moved onto the stack. > Thanks for your explanation, this change will put too much onto the stack in some cases which i didn't consider. Please ignore this change. > Please, learn more about what you're doing. I suggest sending patches > to drivers/staging; that will help you learn how to submit patches to > linux.