From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD78AC433DB for ; Wed, 30 Dec 2020 12:42:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C28182220B for ; Wed, 30 Dec 2020 12:42:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C28182220B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C38338D0084; Wed, 30 Dec 2020 07:42:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9678D007F; Wed, 30 Dec 2020 07:42:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B27558D0084; Wed, 30 Dec 2020 07:42:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 9D0DC8D007F for ; Wed, 30 Dec 2020 07:42:46 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 68D308249980 for ; Wed, 30 Dec 2020 12:42:46 +0000 (UTC) X-FDA: 77649912732.20.sheep92_34163ba274a5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 46CD9180C07AB for ; Wed, 30 Dec 2020 12:42:46 +0000 (UTC) X-HE-Tag: sheep92_34163ba274a5 X-Filterd-Recvd-Size: 2015 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Dec 2020 12:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GFv7dLiw0NpGHZG0c6KE16f5Mn2s1/PKG0D3EAXZlPg=; b=uN/ggEkRMYWqEeLgaDS0WEauPE ovr2dGeW22qLxFinoQ3HQw/jht1QBOn3NHnINc7l6Febx4iec63rXVLHg0MsNjAmB2lH3CpcwdhHp ydmxXJH98wiYjyMvX1jeaFpRMSchSy5sTWnjoZdvWq8UWYSKojnT8ShdhTyinN3UnduhQMdAgplaw Ri+P6xo1M/rdZXBdXZsJY7mjelKw3iCYuim786Zvre4qNWFxEWOlvA2SR06bubgHDXnrE/lS6NgK9 cyG+mpGFBuquSvUm/u/1RdkIImRIID0m7Z3KnwkNdAHsYxa6vd22CjTkubmagNl4e3d7LRoxlgkH2 +skMHlKA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kuaoD-001IVR-LA; Wed, 30 Dec 2020 12:42:34 +0000 Date: Wed, 30 Dec 2020 12:42:33 +0000 From: Matthew Wilcox To: Hui Su Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH] mm/page_alloc: remove the static for local variable node_order Message-ID: <20201230124233.GE28221@casper.infradead.org> References: <20201230114014.GA1934427@ubuntu-A520I-AC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230114014.GA1934427@ubuntu-A520I-AC> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > local variable node_order do not need the static here. It bloody well does. It can be up to 2^10 entries on x86 (and larger on others) That's 4kB which you've now moved onto the stack. Please, learn more about what you're doing. I suggest sending patches to drivers/staging; that will help you learn how to submit patches to linux.