From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B1EC433DB for ; Wed, 23 Dec 2020 12:11:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19B752246B for ; Wed, 23 Dec 2020 12:11:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19B752246B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39AE18D0023; Wed, 23 Dec 2020 07:11:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C518D0001; Wed, 23 Dec 2020 07:11:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2136D8D0023; Wed, 23 Dec 2020 07:11:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 0A5898D0001 for ; Wed, 23 Dec 2020 07:11:44 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CE2D61F08 for ; Wed, 23 Dec 2020 12:11:43 +0000 (UTC) X-FDA: 77624432886.11.rain90_1207d8d27468 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id A8F55180F8B81 for ; Wed, 23 Dec 2020 12:11:43 +0000 (UTC) X-HE-Tag: rain90_1207d8d27468 X-Filterd-Recvd-Size: 2209 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 12:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8oaG0qKqyS1F6NiV0JGgSi0wPiRzch5yyHCD8liSGYg=; b=k5jgYvcwhPV8Yd9aVd3xqH0GHX mAk+cTRNgTcC49Y1IpJ9fcJtYYtLHo2lY45wUWgGP7TBbo64BwsmdPAJZLbz6dVbzoqRjltpfOrU9 CuXdIVz8aElqF1RtDJ78UH9oZ1qh1yfKTb2SLWaMH1ZeU01WAdUYCkLwmtSsOL7j1cobMva/RutPV zFchi+aq9/aRvpaRFPnuQ4afqKN3sPsPIroaH5ySCYT95oZ7UNVqF+PRl0lC7kL1x8KSW8YKv2IWn yaBMvKVk4Fi8L0wiVdw1AQXH+CAm4jsS+AVtwKYB+/ny+FyJw4SRqWIMd6pL1nRp6EwWureYZbxf3 MrTv4iZA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ks2zQ-0003tT-8c; Wed, 23 Dec 2020 12:11:36 +0000 Date: Wed, 23 Dec 2020 12:11:36 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Souptick Joarder , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alex Shi Subject: Re: [PATCH] mm: add prototype for __add_to_page_cache_locked() Message-ID: <20201223121136.GP874@casper.infradead.org> References: <1608646792-29073-1-git-send-email-jrdr.linux@gmail.com> <20201222204000.GN874@casper.infradead.org> <20201222155345.e7086ad37967c9b7feae29e4@linux-foundation.org> <20201223083126.GA27049@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201223083126.GA27049@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 08:31:26AM +0000, Christoph Hellwig wrote: > Can we please make the eBPF code stop referencing this function instead > of papering over this crap? It has no business poking into page cache > internals. The reference from the BPF code is simply "you can inject errors here". And I think we want to be able to inject errors to test the error paths, no?