From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72FE1C4332B for ; Mon, 21 Dec 2020 19:38:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E5C122BE9 for ; Mon, 21 Dec 2020 19:38:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E5C122BE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF61B6B005C; Mon, 21 Dec 2020 14:38:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCC466B005D; Mon, 21 Dec 2020 14:38:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D09CD6B0068; Mon, 21 Dec 2020 14:38:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id B84E46B005C for ; Mon, 21 Dec 2020 14:38:30 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8200252C1 for ; Mon, 21 Dec 2020 19:38:30 +0000 (UTC) X-FDA: 77618301180.24.moon13_2d076f327459 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 6A90D1A4A0 for ; Mon, 21 Dec 2020 19:38:30 +0000 (UTC) X-HE-Tag: moon13_2d076f327459 X-Filterd-Recvd-Size: 2425 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 19:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VVCXpUDKZzGEDshlIyWXlUHpNYdWbBRAq78poeXofdI=; b=r55bTdXZTH/mflDLxLGDJb+Akq RVIBwYOVRIn/jX0IkKB03d7pc0hJWequR/Zce6oQnMCWVpZgDqYsrcpDJhkQSWegzWM3CDI2StLxT 5acwwkkImKnRZlWYjNIcHSDNFFUehQactmtg10HehbMW+yb3lt2ZGvQIkEv456kV96lb/V3iyG0+b ZwWmiy5tXDfrwaCaHSMTd1BEUmXzG98xKoubfv6HORCzXzayV/Atib8AnshInmlrMg6SWOXtDFfmW /fx9VrpP7miJOBRoruURjbUKA5WWmQGkx2yf0wjoc46uHw68Qm7Rij2jSaTExddYkKvS6XT6YeY7k +VaxImhA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1krR0f-0005GV-FL; Mon, 21 Dec 2020 19:38:21 +0000 Date: Mon, 21 Dec 2020 19:38:21 +0000 From: Matthew Wilcox To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Dan Carpenter , Michal Hocko , Davidlohr Bueso , Andrew Morton Subject: Re: [PATCH 1/2] mm/hugetlb: change hugetlb_reserve_pages() to type bool Message-ID: <20201221193821.GF874@casper.infradead.org> References: <20201221192542.15732-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201221192542.15732-1-mike.kravetz@oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 21, 2020 at 11:25:41AM -0800, Mike Kravetz wrote: > While reviewing a bug in hugetlb_reserve_pages, it was noticed that all > callers ignore the return value. Any failure is considered an ENOMEM > error by the callers. > > Change the function to be of type bool. The function will return true > if the reservation was successful, false otherwise. Callers currently > assume a zero return code indicates success. Change the callers to look > for true to indicate success. No functional change, only code cleanup. > > Signed-off-by: Mike Kravetz Reviewed-by: Matthew Wilcox (Oracle)