From: Matthew Wilcox <willy@infradead.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michal Hocko <mhocko@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mm/hugetlb: change hugetlb_reserve_pages() to type bool
Date: Mon, 21 Dec 2020 19:38:21 +0000 [thread overview]
Message-ID: <20201221193821.GF874@casper.infradead.org> (raw)
In-Reply-To: <20201221192542.15732-1-mike.kravetz@oracle.com>
On Mon, Dec 21, 2020 at 11:25:41AM -0800, Mike Kravetz wrote:
> While reviewing a bug in hugetlb_reserve_pages, it was noticed that all
> callers ignore the return value. Any failure is considered an ENOMEM
> error by the callers.
>
> Change the function to be of type bool. The function will return true
> if the reservation was successful, false otherwise. Callers currently
> assume a zero return code indicates success. Change the callers to look
> for true to indicate success. No functional change, only code cleanup.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
prev parent reply other threads:[~2020-12-21 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 19:25 Mike Kravetz
2020-12-21 19:25 ` [PATCH 2/2] hugetlbfs: remove special hugetlbfs_set_page_dirty() Mike Kravetz
2020-12-21 19:38 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221193821.GF874@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox