* Re: [PATCH v1 02/13] sparc32: Drop floppy support
[not found] <20201218184347.2180772-3-sam@ravnborg.org>
@ 2020-12-19 19:15 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-12-19 19:15 UTC (permalink / raw)
To: Sam Ravnborg, David S Miller, sparclinux, Andreas Larsson, Arnd Bergmann
Cc: kbuild-all, Alexey Dobriyan, Al Viro, Andrew Morton,
Linux Memory Management List, Anshuman Khandual, Arvind Sankar
[-- Attachment #1: Type: text/plain, Size: 3582 bytes --]
Hi Sam,
I love your patch! Perhaps something to improve:
[auto build test WARNING on soc/for-next]
[also build test WARNING on sparc/master v5.10 next-20201218]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/sparc32-sunset-sun4m-and-sun4d/20201219-025354
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/00216b8cb055593d3f761d58e2f167ef4b425871
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sam-Ravnborg/sparc32-sunset-sun4m-and-sun4d/20201219-025354
git checkout 00216b8cb055593d3f761d58e2f167ef4b425871
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/block/floppy.c:251:
>> arch/sparc/include/asm/floppy.h:200:13: warning: no previous prototype for 'sparc_floppy_irq' [-Wmissing-prototypes]
200 | irqreturn_t sparc_floppy_irq(int irq, void *dev_cookie)
| ^~~~~~~~~~~~~~~~
In file included from drivers/block/floppy.c:251:
>> arch/sparc/include/asm/floppy.h:437:6: warning: no previous prototype for 'sun_pci_fd_dma_callback' [-Wmissing-prototypes]
437 | void sun_pci_fd_dma_callback(struct ebus_dma_info *p, int event, void *cookie)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/sparc_floppy_irq +200 arch/sparc/include/asm/floppy.h
199
> 200 irqreturn_t sparc_floppy_irq(int irq, void *dev_cookie)
201 {
202 if (likely(doing_pdma)) {
203 void __iomem *stat = (void __iomem *) fdc_status;
204 unsigned char *vaddr = pdma_vaddr;
205 unsigned long size = pdma_size;
206 u8 val;
207
208 while (size) {
209 val = readb(stat);
210 if (unlikely(!(val & 0x80))) {
211 pdma_vaddr = vaddr;
212 pdma_size = size;
213 return IRQ_HANDLED;
214 }
215 if (unlikely(!(val & 0x20))) {
216 pdma_vaddr = vaddr;
217 pdma_size = size;
218 doing_pdma = 0;
219 goto main_interrupt;
220 }
221 if (val & 0x40) {
222 /* read */
223 *vaddr++ = readb(stat + 1);
224 } else {
225 unsigned char data = *vaddr++;
226
227 /* write */
228 writeb(data, stat + 1);
229 }
230 size--;
231 }
232
233 pdma_vaddr = vaddr;
234 pdma_size = size;
235
236 /* Send Terminal Count pulse to floppy controller. */
237 val = readb(auxio_register);
238 val |= AUXIO_AUX1_FTCNT;
239 writeb(val, auxio_register);
240 val &= ~AUXIO_AUX1_FTCNT;
241 writeb(val, auxio_register);
242
243 doing_pdma = 0;
244 }
245
246 main_interrupt:
247 return floppy_interrupt(irq, dev_cookie);
248 }
249
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67961 bytes --]
^ permalink raw reply [flat|nested] only message in thread