From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABDBC4361B for ; Fri, 18 Dec 2020 12:18:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6322723443 for ; Fri, 18 Dec 2020 12:18:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6322723443 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C37E6B005D; Fri, 18 Dec 2020 07:18:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 874636B0068; Fri, 18 Dec 2020 07:18:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 762F46B006C; Fri, 18 Dec 2020 07:18:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 6218F6B005D for ; Fri, 18 Dec 2020 07:18:00 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 247AF8249980 for ; Fri, 18 Dec 2020 12:18:00 +0000 (UTC) X-FDA: 77606304720.23.edge61_63087002743d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 03E7137604 for ; Fri, 18 Dec 2020 12:17:59 +0000 (UTC) X-HE-Tag: edge61_63087002743d X-Filterd-Recvd-Size: 1752 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 12:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I6Jc1yJjcNRC/skT3yP0vC8c2+p2pnxaOzpHPFUwwOA=; b=AOVmnq/OYugj7hrwBq6E0fUU+3 L46xEaZCG5ccilFMkBnAe6XgAx9OM7OiQc1G5CPSEoSkVOhIHaDDEvxDQNka9U1DqqYppcWO2u0NZ l7RAfbsLNHXW3fROkLTBSQttgh5nDLLaG5a1I8/372S15q7tHN6Pa/O2nQJ6JzRnMJRK76YVUclmv 1QK21mB7MgDSwO1MvlnvLaXDp02wspjb5OmHeOvP/SNc+izzMCwQzdmhXOD2fvgPeytyXnceNe33m jxaV21oVi9VKoJq/NocLl5yOdEfoMr9OE/lGB3l6T7lgBBW0w2sychLlufVVaLH1KEB9t40QIqx+z NA80GEdg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqEhk-00071q-Sa; Fri, 18 Dec 2020 12:17:52 +0000 Date: Fri, 18 Dec 2020 12:17:52 +0000 From: Matthew Wilcox To: Jacob Wen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages() Message-ID: <20201218121752.GK15600@casper.infradead.org> References: <20201218102217.186836-1-jian.w.wen@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201218102217.186836-1-jian.w.wen@oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 18, 2020 at 06:22:17PM +0800, Jacob Wen wrote: > This patch reduces repetition of set_task_reclaim_state() around > do_try_to_free_pages(). what is a DRY cleanup?