From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8879CC4361B for ; Fri, 18 Dec 2020 18:02:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08B5C23B76 for ; Fri, 18 Dec 2020 18:02:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B5C23B76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47EE96B005C; Fri, 18 Dec 2020 13:02:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4304E6B005D; Fri, 18 Dec 2020 13:02:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36D046B0068; Fri, 18 Dec 2020 13:02:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 1D78E6B005C for ; Fri, 18 Dec 2020 13:02:05 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CC54D18222A0B for ; Fri, 18 Dec 2020 18:02:04 +0000 (UTC) X-FDA: 77607171768.10.rate28_430f7c32743f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id A323216A4B7 for ; Fri, 18 Dec 2020 18:02:04 +0000 (UTC) X-HE-Tag: rate28_430f7c32743f X-Filterd-Recvd-Size: 2545 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 18:02:04 +0000 (UTC) Date: Fri, 18 Dec 2020 10:02:02 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608314523; bh=XgkIqGAMCUBzOB+Eld9RGGbpub7QI9DQIGW7IxOfMzY=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=hH+BBpkm9FOgaOPDxTz3h/wbt/Vqk0MdtjOJqsBJbMeU1pmsueoEehMb+1m2N/uWk n1rsdaTTsFvFA1Uy9ABPdYUbKO1V9Ng4OXpoydPX3A5/Wbfyw/YqIgqfxN1/VbYoLO P06/fRFo2nfVIkMJNOqNitBb7hel07EjgEv5SIwc= From: Andrew Morton To: hui yang Cc: linux-mm@kvack.org Subject: Re: [PATCH] mm: reduced code declaration Message-Id: <20201218100202.6d338b190b6c8918efb78ea2@linux-foundation.org> In-Reply-To: <1608287569-4689-1-git-send-email-yanghui.def@gmail.com> References: <1608287569-4689-1-git-send-email-yanghui.def@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Dec 2020 18:32:49 +0800 hui yang wrote: > From: YangHui > > make code more formal. > > ... > > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2425,7 +2425,7 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) > { > unsigned long nr[NR_LRU_LISTS]; > unsigned long targets[NR_LRU_LISTS]; > - unsigned long nr_to_scan; > + unsigned long nr_to_scan, scan_target; > enum lru_list lru; > unsigned long nr_reclaimed = 0; > unsigned long nr_to_reclaim = sc->nr_to_reclaim; > @@ -2492,12 +2492,12 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) > break; > > if (nr_file > nr_anon) { > - unsigned long scan_target = targets[LRU_INACTIVE_ANON] + > + scan_target = targets[LRU_INACTIVE_ANON] + > targets[LRU_ACTIVE_ANON] + 1; > lru = LRU_BASE; > percentage = nr_anon * 100 / scan_target; > } else { > - unsigned long scan_target = targets[LRU_INACTIVE_FILE] + > + scan_target = targets[LRU_INACTIVE_FILE] + > targets[LRU_ACTIVE_FILE] + 1; > lru = LRU_FILE; > percentage = nr_file * 100 / scan_target; I tend to prefer the original code - this change gives scan_target function-wide scope, which it does not need. Makes it harder for the reader to understand where and why this variable is used.