From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75294C4361B for ; Thu, 17 Dec 2020 12:02:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 01DD42395A for ; Thu, 17 Dec 2020 12:02:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01DD42395A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25F766B0036; Thu, 17 Dec 2020 07:02:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E77C6B005D; Thu, 17 Dec 2020 07:02:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AF4B6B0068; Thu, 17 Dec 2020 07:02:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id E31856B0036 for ; Thu, 17 Dec 2020 07:02:02 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8F9DB3626 for ; Thu, 17 Dec 2020 12:02:02 +0000 (UTC) X-FDA: 77602635684.08.kite50_110a73627434 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 66A3E1819E773 for ; Thu, 17 Dec 2020 12:02:02 +0000 (UTC) X-HE-Tag: kite50_110a73627434 X-Filterd-Recvd-Size: 4398 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Dec 2020 12:02:00 +0000 (UTC) IronPort-SDR: MXaj+2zSyYFpgcDIThqf3XKJVGuYjDwZigAQU5PeOPHWcJHwGj5oJGrKFQ4x5jb8Av5c1uHF8K b6GCqVUWYRPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9837"; a="162287410" X-IronPort-AV: E=Sophos;i="5.78,427,1599548400"; d="scan'208";a="162287410" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 04:01:59 -0800 IronPort-SDR: L7XrsWPv9JxaN9xmMmPdvpjGsr7zebuNLV2Y99+fMTn4NCU1nFJTsV7Y4c0ZXPZQwi0Q7pDFw7 nq4xOTFOMm8g== X-IronPort-AV: E=Sophos;i="5.78,427,1599548400"; d="scan'208";a="387487451" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 04:01:57 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kprzm-00F0AE-R0; Thu, 17 Dec 2020 14:02:58 +0200 Date: Thu, 17 Dec 2020 14:02:58 +0200 From: Andy Shevchenko To: David Gow Cc: Linus Torvalds , Andrew Morton , Shuah Khan , Brendan Higgins , Mark Brown , Linux-MM , "Vaittinen, Matti" , mm-commits@vger.kernel.org, Vitor Massaru Iha Subject: Re: [patch 18/95] lib/list_kunit: follow new file name convention for KUnit tests Message-ID: <20201217120258.GP4077@smile.fi.intel.com> References: <20201215204156.f05ec694b907845bcfab5c44@linux-foundation.org> <20201216044316.LYocMD9yH%akpm@linux-foundation.org> <20201216104142.GY4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 17, 2020 at 05:21:00PM +0800, David Gow wrote: > On Wed, Dec 16, 2020 at 6:41 PM Andy Shevchenko > wrote: > > On Wed, Dec 16, 2020 at 02:53:10PM +0800, David Gow wrote: > > > On Wed, Dec 16, 2020 at 2:02 PM Linus Torvalds > > > wrote: ... > > > > Don't send me any more rename patches until your tools can actually do renames. > > > > > My other thought is that this sort of patchset really makes more sense > > > to push through the kselftest/kunit branch anyway, as all of the > > > changes were really more KUnit related than anything else. Does it > > > make sense to re-submit this that way? > > > > I think it makes sense because this is driven by rules set up by kselftest/kunit. > > My main concern here is to have cmdline_kunit in the tree (it is a new file). > > Renaming is up to you, I just wanted to be consistent with names and KUnit > > documentation. > > It looks like the cmdline_kunit changes have been merged now, so it's > a relief that those weren't held up: I agree that they're the more > important changes. Yes, they are in, thanks Linus! > I do think renaming things to match the new convention is a good idea > (so thanks again for doing that), but it's not exactly an urgent fix. > My preference is that these get added to one of the kunit branches in > the kselftest repo, so they can be picked up when convenient. This > should just be the first three patches in this series: > https://lore.kernel.org/linux-kselftest/20201112180732.75589-1-andriy.shevchenko@linux.intel.com/ > > I'd expect those to still apply pretty cleanly, but I haven't actually > checked yet. They won't apply after v5.11-rc1 due to cmdline_kunit entry. I can rebase after rc1 and send it to KUnit/kselftest mailing lists. Andrew, please drop these patches from your quilt and thanks for carrying them. -- With Best Regards, Andy Shevchenko