From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C091C4361B for ; Wed, 16 Dec 2020 22:01:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3668238E4 for ; Wed, 16 Dec 2020 22:01:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3668238E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03F426B0036; Wed, 16 Dec 2020 17:01:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F32C66B005C; Wed, 16 Dec 2020 17:01:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E491C6B005D; Wed, 16 Dec 2020 17:01:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id CCF1E6B0036 for ; Wed, 16 Dec 2020 17:01:06 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8EF71180AD81A for ; Wed, 16 Dec 2020 22:01:06 +0000 (UTC) X-FDA: 77600516532.21.sheep48_05117a32742f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 20422180442D0 for ; Wed, 16 Dec 2020 22:01:06 +0000 (UTC) X-HE-Tag: sheep48_05117a32742f X-Filterd-Recvd-Size: 2991 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 22:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ytTtA1pALsETtIdSlU2w2vhrdzWxtF525/d1jU/Olhk=; b=OQkDQdH5oa7t9KfGEUOOkn/7wF csKPl20Zi97hVOEgPUOkonLH7r0yJsPh15fKEEJaZwhwusE22H4ajnaZlnArkECHS9yjyyXBctJ1g UH9Ez31bSdeOnlkfRRumx6yYLXHKEyazefcQsWkq3m+xZOjqFxeqbtG7OO99lElWCuUsvCReeFqro Qgc+wnoKZE4xrJ+F9DmTVYh4PRv5MNLSqPTIv2JZyXVoJEiyZTNd4o6lrOzldOo1RXeIdMhGbYLKN l93vPP6ee2QUMMq4FTdWqUb3D74+tFIWfkVsjEgkvi3LJUUlrGbvX61qoEvuWiHd6sD/Yqb6fk+YZ iu+fQmDg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpeqy-000365-QT; Wed, 16 Dec 2020 22:01:00 +0000 Date: Wed, 16 Dec 2020 22:01:00 +0000 From: Matthew Wilcox To: kernel test robot Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 23/25] mm: Add flush_dcache_folio Message-ID: <20201216220100.GY2443@casper.infradead.org> References: <20201216182335.27227-24-willy@infradead.org> <202012170425.x32aFRjm-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202012170425.x32aFRjm-lkp@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 17, 2020 at 04:59:21AM +0800, kernel test robot wrote: > All errors (new ones prefixed by >>): > > In file included from arch/powerpc/include/asm/cacheflush.h:111, > from include/linux/highmem.h:12, > from include/linux/pagemap.h:11, > from include/linux/blkdev.h:14, > from include/linux/blk-cgroup.h:23, > from include/linux/writeback.h:14, > from include/linux/memcontrol.h:22, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from arch/powerpc/kernel/asm-offsets.c:23: > include/asm-generic/cacheflush.h: In function 'flush_dcache_folio': > >> include/asm-generic/cacheflush.h:64:33: error: subscripted value is neither array nor pointer nor vector > 64 | flush_dcache_page(&folio->page[--n]); Thanks. Apparently I need to compile on more than just x86 ;-) This compiles on aargh64: @@ -61,7 +61,8 @@ static inline void flush_dcache_folio(struct folio *folio) unsigned int n = folio_nr_pages(folio); do { - flush_dcache_page(&folio->page[--n]); + n--; + flush_dcache_page(&folio->page + n); } while (n); } #endif I'll fold it into my git tree.