From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D1E3C4361B for ; Wed, 16 Dec 2020 04:42:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A28423340 for ; Wed, 16 Dec 2020 04:42:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A28423340 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B87DB6B006C; Tue, 15 Dec 2020 23:42:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B37AE6B006E; Tue, 15 Dec 2020 23:42:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A27796B0070; Tue, 15 Dec 2020 23:42:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 8DDDD6B006C for ; Tue, 15 Dec 2020 23:42:32 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5E574180AD81F for ; Wed, 16 Dec 2020 04:42:32 +0000 (UTC) X-FDA: 77597899344.04.way33_28169c427429 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 3D5FE8008008 for ; Wed, 16 Dec 2020 04:42:32 +0000 (UTC) X-HE-Tag: way33_28169c427429 X-Filterd-Recvd-Size: 2487 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 04:42:31 +0000 (UTC) Date: Tue, 15 Dec 2020 20:42:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608093750; bh=SycMikhgQKZbcj+vyD93K7LGP1ppNlRHLSNuj8zaYHk=; h=From:To:Subject:In-Reply-To:From; b=pLtA1NrHqSpeSMbG8mw/n1ih1l9vAftg7uMQ4JQ6HPGTTJEjO2zNB+5lkQ0Gu0FYi TV4xwy2jyYFGQo1VN8La7N9ac3n0e1L5M71Lrx41TpL3XdvVwd/t0LC+BVTRsanyxO 74geg8Dk4BFx3YO9hBXXTuS9Ykj5ytProqj3mmUs= From: Andrew Morton To: akpm@linux-foundation.org, belyshev@depni.sinp.msu.ru, bigeasy@linutronix.de, ink@jurassic.park.msu.ru, linux-mm@kvack.org, mattst88@gmail.com, mm-commits@vger.kernel.org, rth@twiddle.net, tglx@linutronix.de, torvalds@linux-foundation.org Subject: [patch 03/95] alpha: replace bogus in_interrupt() Message-ID: <20201216044229.2LRiyYBCE%akpm@linux-foundation.org> In-Reply-To: <20201215204156.f05ec694b907845bcfab5c44@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Thomas Gleixner Subject: alpha: replace bogus in_interrupt() in_interrupt() is true for a variety of things including bottom half disabled regions. Deducing hard interrupt context from it is dubious at best. Use in_irq() which is true if called in hard interrupt context. Otherwise calling irq_exit() would do more harm than good. Link: https://lkml.kernel.org/r/20201113135832.2202833-1-bigeasy@linutronix.de Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior Tested-by: Serge Belyshev Cc: Richard Henderson Cc: Matt Turner Cc: Ivan Kokshaysky Signed-off-by: Andrew Morton --- arch/alpha/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/alpha/kernel/process.c~alpha-replace-bogus-in_interrupt +++ a/arch/alpha/kernel/process.c @@ -134,7 +134,7 @@ common_shutdown_1(void *generic_ptr) #ifdef CONFIG_DUMMY_CONSOLE /* If we've gotten here after SysRq-b, leave interrupt context before taking over the console. */ - if (in_interrupt()) + if (in_irq()) irq_exit(); /* This has the effect of resetting the VGA video origin. */ console_lock(); _