From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE229C2BB9A for ; Tue, 15 Dec 2020 14:50:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF5B62251E for ; Tue, 15 Dec 2020 14:50:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF5B62251E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2D8046B006E; Tue, 15 Dec 2020 09:50:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 287D36B0070; Tue, 15 Dec 2020 09:50:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19E0B6B0071; Tue, 15 Dec 2020 09:50:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F3AA06B006E for ; Tue, 15 Dec 2020 09:50:44 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AC87A2C8F for ; Tue, 15 Dec 2020 14:50:44 +0000 (UTC) X-FDA: 77595803208.10.ear63_3d028b927424 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 7AE7D16A4C6 for ; Tue, 15 Dec 2020 14:50:44 +0000 (UTC) X-HE-Tag: ear63_3d028b927424 X-Filterd-Recvd-Size: 2029 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 14:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SP8YFINVPRnhThewKPK7I5XpcEcBBVki7EiNwPcf1fc=; b=luZF/e7osMddljt2htKndpuFEp l/jNb5iedS8YIq6K3EVwCXOEZyJ/ruzqR3vxmGZopX9mZHSrUl8m9J/BZAmkY3wnVROGmxMczLHuY h1Syot32XN2M9f2645NlPoTRjdkAUV2+hnsQnWnHIwvbX4+UV/cyP6Ur8JVazHrbUfjbDu8dqay+a vsbnsQ84Gt4GAwOCgAapaBFeTAvwrebf1SPjFcupXyzwQNQ8mAyxaNkR14XuNMf0YBanrkDFogrRl D/jZEcC8vx3ZADUMsdhaHRQYJS0muf5gOP90mQPa1C3rnsM+L5lV4NxcM+qMWShFv4tWzMExXlyUG FmRpalcQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpBey-0004lg-Mx; Tue, 15 Dec 2020 14:50:41 +0000 Date: Tue, 15 Dec 2020 14:50:40 +0000 From: Matthew Wilcox To: "Liam R. Howlett" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] mm/mmap: Don't unlock VMAs in remap_file_pages() Message-ID: <20201215145040.GT2443@casper.infradead.org> References: <20201215141300.1436976-1-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201215141300.1436976-1-Liam.Howlett@Oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 15, 2020 at 09:13:00AM -0500, Liam R. Howlett wrote: > @@ -3025,25 +3025,6 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > > flags &= MAP_NONBLOCK; > flags |= MAP_SHARED | MAP_FIXED | MAP_POPULATE; > - if (vma->vm_flags & VM_LOCKED) { > - struct vm_area_struct *tmp; > - flags |= MAP_LOCKED; I think you need to keep ^^^ that line because the vma needs to stay mlocked.