From: Matthew Wilcox <willy@infradead.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@google.com>
Subject: Re: [PATCH] mm/mmap: Don't unlock VMAs in remap_file_pages()
Date: Tue, 15 Dec 2020 14:50:40 +0000 [thread overview]
Message-ID: <20201215145040.GT2443@casper.infradead.org> (raw)
In-Reply-To: <20201215141300.1436976-1-Liam.Howlett@Oracle.com>
On Tue, Dec 15, 2020 at 09:13:00AM -0500, Liam R. Howlett wrote:
> @@ -3025,25 +3025,6 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
>
> flags &= MAP_NONBLOCK;
> flags |= MAP_SHARED | MAP_FIXED | MAP_POPULATE;
> - if (vma->vm_flags & VM_LOCKED) {
> - struct vm_area_struct *tmp;
> - flags |= MAP_LOCKED;
I think you need to keep ^^^ that line because the vma needs to stay
mlocked.
next prev parent reply other threads:[~2020-12-15 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 14:13 Liam R. Howlett
2020-12-15 14:50 ` Matthew Wilcox [this message]
2020-12-15 15:40 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215145040.GT2443@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox