From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74F0C4361B for ; Tue, 15 Dec 2020 03:15:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7208B22509 for ; Tue, 15 Dec 2020 03:15:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7208B22509 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D1288D008C; Mon, 14 Dec 2020 22:15:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F26148D001C; Mon, 14 Dec 2020 22:15:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E13A28D008C; Mon, 14 Dec 2020 22:15:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id C70488D001C for ; Mon, 14 Dec 2020 22:15:02 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9B1BD3631 for ; Tue, 15 Dec 2020 03:15:02 +0000 (UTC) X-FDA: 77594050044.17.cow12_3512c0a27420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 7CE10180D0194 for ; Tue, 15 Dec 2020 03:15:02 +0000 (UTC) X-HE-Tag: cow12_3512c0a27420 X-Filterd-Recvd-Size: 2392 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:15:02 +0000 (UTC) Date: Mon, 14 Dec 2020 19:15:00 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608002101; bh=sVFUy8U6+oXlHMBlb3TTMhm0RRavMuDvO8kiF0Vyg6E=; h=From:To:Subject:In-Reply-To:From; b=gCBuX8BlpQ4i9YfczTnldYX1cM/44S1dpGHbcSMHJ7v+182IWCsWYk6Fvj28nFVlC RhqxtQO5PzkLA0xS2HsvXLLpqYG8A2OeEAoxal0HfUbLTi9GFE8yh1iQXVA9daRQyI DLXmN/FmI8dxMIDOtWp6jYGOk0NaouuBxAgvgitk= From: Andrew Morton To: akpm@linux-foundation.org, gustavoars@kernel.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 199/200] mm: fix fall-through warnings for Clang Message-ID: <20201215031500.vysL6-o3U%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Gustavo A. R. Silva" Subject: mm: fix fall-through warnings for Clang In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a break statement instead of just letting the code fall through to the next, and by adding a fallthrough pseudo-keyword in places where the code is intended to fall through. Link: https://github.com/KSPP/linux/issues/115 Link: https://lkml.kernel.org/r/f5756988b8842a3f10008fbc5b0a654f828920a9.1605896059.git.gustavoars@kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Andrew Morton --- mm/mm_init.c | 1 + mm/vmscan.c | 1 + 2 files changed, 2 insertions(+) --- a/mm/mm_init.c~mm-fix-fall-through-warnings-for-clang +++ a/mm/mm_init.c @@ -173,6 +173,7 @@ static int __meminit mm_compute_batch_no case MEM_ONLINE: case MEM_OFFLINE: mm_compute_batch(sysctl_overcommit_memory); + break; default: break; } --- a/mm/vmscan.c~mm-fix-fall-through-warnings-for-clang +++ a/mm/vmscan.c @@ -1369,6 +1369,7 @@ static unsigned int shrink_page_list(str if (PageDirty(page) || PageWriteback(page)) goto keep_locked; mapping = page_mapping(page); + fallthrough; case PAGE_CLEAN: ; /* try to free the page below */ } _