From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9B7C4361B for ; Tue, 15 Dec 2020 03:12:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BFFD22A99 for ; Tue, 15 Dec 2020 03:12:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BFFD22A99 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0ACCA8D005A; Mon, 14 Dec 2020 22:12:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05C368D001C; Mon, 14 Dec 2020 22:12:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB4DC8D005A; Mon, 14 Dec 2020 22:12:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id D16288D001C for ; Mon, 14 Dec 2020 22:12:07 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A42AD180AD83E for ; Tue, 15 Dec 2020 03:12:07 +0000 (UTC) X-FDA: 77594042694.03.jail53_190187d27420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 87C4428A4E9 for ; Tue, 15 Dec 2020 03:12:07 +0000 (UTC) X-HE-Tag: jail53_190187d27420 X-Filterd-Recvd-Size: 2802 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:12:07 +0000 (UTC) Date: Mon, 14 Dec 2020 19:12:05 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001926; bh=PHSp0F2R2WjJ2x8B1CwUz60l5UETzXOWbVBzqxtg+uE=; h=From:To:Subject:In-Reply-To:From; b=Jy/SDUSn5RcVmn1kcufgpsSRnqSWOKZ2l8J8xA3JW3WIpyjRHVXY1E08QnJi0LwQy 6Lf+53/fHb72tVnY8pSuAD3rJigj7GTXGkvD6hwwV4Ut2nfGcRLAyChyPidx8gi6M0 kxvN3Mavv1+hAq1gxPlCH/lpnUjr76SpcoYREsSU= From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, liu.xiang@zlingsmart.com, liuxiang_1999@126.com, ma.chenggong@zlingsmart.com, mike.kravetz@oracle.com, mm-commits@vger.kernel.org, pan.jiagen@zlingsmart.com, torvalds@linux-foundation.org Subject: [patch 149/200] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages() Message-ID: <20201215031205.IRg2pwdxl%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Liu Xiang Subject: mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages() On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit value now. So we need to fix type of delta parameter and related local variables in gather_surplus_pages(). Link: https://lkml.kernel.org/r/1605793733-3573-1-git-send-email-liu.xiang@zlingsmart.com Reported-by: Ma Chenggong Signed-off-by: Liu Xiang Signed-off-by: Pan Jiagen Reviewed-by: Mike Kravetz Cc: Liu Xiang Signed-off-by: Andrew Morton --- mm/hugetlb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/mm/hugetlb.c~mm-hugetlb-fix-type-of-delta-parameter-and-related-local-variables-in-gather_surplus_pages +++ a/mm/hugetlb.c @@ -1944,13 +1944,14 @@ struct page *alloc_huge_page_vma(struct * Increase the hugetlb pool such that it can accommodate a reservation * of size 'delta'. */ -static int gather_surplus_pages(struct hstate *h, int delta) +static int gather_surplus_pages(struct hstate *h, long delta) __must_hold(&hugetlb_lock) { struct list_head surplus_list; struct page *page, *tmp; - int ret, i; - int needed, allocated; + int ret; + long i; + long needed, allocated; bool alloc_ok = true; needed = (h->resv_huge_pages + delta) - h->free_huge_pages; _