From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C933C4361B for ; Mon, 14 Dec 2020 06:30:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A00E722582 for ; Mon, 14 Dec 2020 06:30:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A00E722582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B28756B0036; Mon, 14 Dec 2020 01:30:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADA1B6B005C; Mon, 14 Dec 2020 01:30:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C93B6B005D; Mon, 14 Dec 2020 01:30:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 858076B0036 for ; Mon, 14 Dec 2020 01:30:38 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 477723637 for ; Mon, 14 Dec 2020 06:30:38 +0000 (UTC) X-FDA: 77590914156.26.move01_3d11f0727418 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 2AC4D1804B671 for ; Mon, 14 Dec 2020 06:30:38 +0000 (UTC) X-HE-Tag: move01_3d11f0727418 X-Filterd-Recvd-Size: 4766 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Dec 2020 06:30:37 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BE6OjLw135714; Mon, 14 Dec 2020 06:30:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=eTcVx+zYAqt3xiesxfWT+p+5jhqtCGYH972TyzkxRJI=; b=HvFtXlQfp8QpPrFLbgRMLApq8zyjdS80pf5esjgjznwxpvMvMolpJ9tlZsNsaZUdzqzK jmHt50pbZHR4Q25CbkvFcdqxyzELFdo5IV1FjpxNz7J9h0JcGO/r6QZk7J5C5nMhRu7S SY4fjiOZqCEs3nQDjQ9qzDI7DAoemTlKtzhK3UfJrYAuwj6K4YIV5ls1Q1w4HiVdssPQ ZNLiFxgAtrfkHhHgeKMQPmwQBh84AufW+rRMte+Z2+4erGGZxnDwtEbFNNCueWsc+KqH bGUXZL6pb69xl3axS0dG6ta8nqUXXeOOuzwJhLWA7e5i1rNPBI6iw1GErDCdOy1qI99L 7w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 35cn9r3k3c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Dec 2020 06:30:32 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BE6PDir146658; Mon, 14 Dec 2020 06:30:32 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 35d7mphh8f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Dec 2020 06:30:32 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0BE6UT7d006830; Mon, 14 Dec 2020 06:30:30 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 13 Dec 2020 22:30:29 -0800 Date: Mon, 14 Dec 2020 09:30:21 +0300 From: Dan Carpenter To: Souptick Joarder Cc: Mike Kravetz , Mina Almasry , Andrew Morton , David Rientjes , Linux-MM , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] hugetlb: Fix an error code in hugetlb_reserve_pages() Message-ID: <20201214063021.GA2809@kadam> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012140048 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 priorityscore=1501 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012140048 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 12, 2020 at 01:19:28AM +0530, Souptick Joarder wrote: > Hi Dan, > > On Fri, Dec 11, 2020 at 3:44 PM Dan Carpenter wrote: > > > > Preserve the error code from region_add() instead of returning success. > > > > Fixes: 0db9d74ed884 ("hugetlb: disable region_add file_region coalescing") > > Signed-off-by: Dan Carpenter > > --- > > From static analysis. Untested. > > > > mm/hugetlb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 1f3bf1710b66..ac2e48b9f1d7 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -5113,6 +5113,7 @@ int hugetlb_reserve_pages(struct inode *inode, > > > > if (unlikely(add < 0)) { > > hugetlb_acct_memory(h, -gbl_reserve); > > + ret = add; > > This function returns int but ret is long type. > Does it need correction ? > It doesn't *need* correction. The code works fine as-is. Smatch parses it correctly, also. Hard to say if making it "ret" makes the code simpler or more complicated for a human reader. regards, dan carpenter