From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F85FC4361B for ; Sun, 13 Dec 2020 18:09:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AE7320709 for ; Sun, 13 Dec 2020 18:09:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AE7320709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D2366B0036; Sun, 13 Dec 2020 13:09:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6823A6B005C; Sun, 13 Dec 2020 13:09:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 549F16B005D; Sun, 13 Dec 2020 13:09:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 3ABC56B0036 for ; Sun, 13 Dec 2020 13:09:02 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F41913634 for ; Sun, 13 Dec 2020 18:09:01 +0000 (UTC) X-FDA: 77589045324.26.sleep97_5410ea827414 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id D025A1804B670 for ; Sun, 13 Dec 2020 18:09:01 +0000 (UTC) X-HE-Tag: sleep97_5410ea827414 X-Filterd-Recvd-Size: 3073 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Sun, 13 Dec 2020 18:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607882940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=Jlz332zFWJReTYscol+oPYeopBaK9ZxEFQwZJbYpmjg=; b=XtD5LCnpIvJwbZl9DucuA2nfVR535INTeiqYjXIm9u1iy27OAoy2cb3AjoyUghYueesulR k9PxreQFwauchso5pe1xiwfC7ziGl3j/GYTHyZOKfZqtJncq+45olw81XnrNmd1rNP9ZL7 wkrv5q84y0bauHJwb6CgmiivHuLTy0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-n7S7KqtrOWq5Tu-6s5UIPw-1; Sun, 13 Dec 2020 13:08:58 -0500 X-MC-Unique: n7S7KqtrOWq5Tu-6s5UIPw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92D2559; Sun, 13 Dec 2020 18:08:57 +0000 (UTC) Received: from llong.com (ovpn-112-248.rdu2.redhat.com [10.10.112.248]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D4FB62464; Sun, 13 Dec 2020 18:08:52 +0000 (UTC) From: Waiman Long To: Andrew Morton , "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Waiman Long Subject: [PATCH] mm/vmalloc: Fix unlock order in s_stop() Date: Sun, 13 Dec 2020 13:08:43 -0500 Message-Id: <20201213180843.16938-1-longman@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When multiple locks are acquired, they should be released in reverse order. For s_start() and s_stop() in mm/vmalloc.c, that is not the case. s_start: mutex_lock(&vmap_purge_lock); spin_lock(&vmap_area_lock); s_stop : mutex_unlock(&vmap_purge_lock); spin_unlock(&vmap_area_lock); This unlock sequence, though allowed, is not optimal. If a waiter is present, mutex_unlock() will need to go through the slowpath of waking up the waiter with preemption disabled. Fix that by releasing the spinlock first before the mutex. Fixes: e36176be1c39 ("mm/vmalloc: rework vmap_area_lock") Signed-off-by: Waiman Long --- mm/vmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 6ae491a8b210..75913f685c71 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3448,11 +3448,11 @@ static void *s_next(struct seq_file *m, void *p, loff_t *pos) } static void s_stop(struct seq_file *m, void *p) - __releases(&vmap_purge_lock) __releases(&vmap_area_lock) + __releases(&vmap_purge_lock) { - mutex_unlock(&vmap_purge_lock); spin_unlock(&vmap_area_lock); + mutex_unlock(&vmap_purge_lock); } static void show_numa_info(struct seq_file *m, struct vm_struct *v) -- 2.18.1