From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E7DC433FE for ; Sat, 12 Dec 2020 20:03:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E39ED206FC for ; Sat, 12 Dec 2020 20:03:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E39ED206FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AAD66B0036; Sat, 12 Dec 2020 15:03:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 234696B005C; Sat, 12 Dec 2020 15:03:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FC296B005D; Sat, 12 Dec 2020 15:03:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id E9F5A6B0036 for ; Sat, 12 Dec 2020 15:03:16 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A01761DEE for ; Sat, 12 Dec 2020 20:03:16 +0000 (UTC) X-FDA: 77585704392.02.crown66_0a0cbf72740c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 81A1010097AA1 for ; Sat, 12 Dec 2020 20:03:16 +0000 (UTC) X-HE-Tag: crown66_0a0cbf72740c X-Filterd-Recvd-Size: 4566 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sat, 12 Dec 2020 20:03:15 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id z11so11995638qkj.7 for ; Sat, 12 Dec 2020 12:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2GFQLGUTCQvCE6e8Ung8Jj3pxPp+dowFgia6XDiErlM=; b=dKa2crAArQNoeW/4BVyPAnvSsygMudpoOkonfjIq4PRWzCZvI+6AwwG0CqrsjtIECp RXHH13+ZPuaWw4sblsnI0EA21+9VqMXZ/YpPhkN0ctwkKxhUgbB7qxUf7ulXStfAo6e+ vILBBmHAb2Ap8mVrg6hNM8l/ZFE3WEOewTg+QIyvcJHjFjGbbbB0u51QJkQFFC9oEDkI 41SfAfSfVuGLqi51jhGUN3DXocD+GrZSJ+cjVy+Gtzb0wztwv/ivXDmA+opxbRluCpTH JcdP181AnzdrE+JhVb499+JqbAzQB6lHoeYVdT8aXXww6RjU92eRDa13MzNbd6q0T/uR wBYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2GFQLGUTCQvCE6e8Ung8Jj3pxPp+dowFgia6XDiErlM=; b=SxOdqxOrVFXLBxCM/q4ukSRbshRUJpxGU34mbTc+U4ymonmAoJsVj5+rAFOoXLqs3x zPR+V8I+zl+aSp8Q2rrqwW1vXvLCE6hH+8mm0uQKYaWf+7MhUOux7lDa53fbfdtWX2Ry N+7OvdKlp8ZOL2GBGfVql5X85cTNMbxKw7lOct+1AYtX66TayZoehjiHmMQBXJJ93JKo ywZwZFQfLwTvhsEr2u4L/IcvHO20q303+lsaM2fmuQNJfpockJSlpMnYbKbR6qaLidAd IzqNs2PVfAHmnWeIu6egXGI9Wfh7/2q+Ud9CqNrFzpHC1AneSfx8pA1Bn+ZbfONvncuj z2HQ== X-Gm-Message-State: AOAM531/Uiu+2uceaKn/RR3YE64IfoeZg2dCdFVhPDkXlYI8xclmh0fm l6YO9bu4zfmob/d81amdHn0= X-Google-Smtp-Source: ABdhPJwkneDHdIdUbTqSsb8WeVnJEwQKsrmfcJM5M9qCBxTq2mSEDM9DXJex6r5FnjgC5OFvrMMCpw== X-Received: by 2002:ae9:f507:: with SMTP id o7mr22737418qkg.420.1607803395128; Sat, 12 Dec 2020 12:03:15 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id d66sm11867814qke.132.2020.12.12.12.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Dec 2020 12:03:14 -0800 (PST) Date: Sat, 12 Dec 2020 13:03:12 -0700 From: Nathan Chancellor To: Fabio Estevam Cc: Souptick Joarder , kernel test robot , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Vinod Koul Subject: Re: [linux-next:master 6953/13205] drivers/dma/imx-dma.c:1048:20: warning: cast to smaller integer type 'enum imx_dma_type' from 'const void Message-ID: <20201212200312.GA1773888@ubuntu-m3-large-x86> References: <202012112150.CCpStiwY-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 12, 2020 at 12:40:22PM -0300, Fabio Estevam wrote: > On Fri, Dec 11, 2020 at 11:54 AM Souptick Joarder wrote: > > > of_device_get_match_data() returns void * which is assigned to enum > > imx_dma_type type without extracting > > the value. Anything wrong with the previous assignment ? > > The driver data is now passed via: > imxdma->devtype = (enum imx_dma_type)of_device_get_match_data(&pdev->dev); > > There was nothing wrong with the previous assignment. > > The original driver used to run on non-DT platforms. Now it only runs > on DT-platforms, which means we no longer need the platform data > structure. > > Please note that this a W=1 clang warning. gcc does not complain about it. Correct. The clang developers explicitly wanted this behavior so I moved it under a new warning that could be disabled on regular builds but show up on W=1 in case people wanted to fix these occurrences. https://reviews.llvm.org/D72231 https://github.com/ClangBuiltLinux/linux/issues/887 82f2bc2fcc01 ("kbuild: Disable -Wpointer-to-enum-cast") > Not sure how to make clang happy in this case. Added a cast to unsigned long or uintptr_t before the cast to the enum should fix it. Cheers, Nathan