From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4CEC433FE for ; Fri, 11 Dec 2020 21:46:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5AC5C233A2 for ; Fri, 11 Dec 2020 21:46:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AC5C233A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACF456B0036; Fri, 11 Dec 2020 16:46:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A56BE6B005C; Fri, 11 Dec 2020 16:46:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91E256B005D; Fri, 11 Dec 2020 16:46:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 76E5D6B0036 for ; Fri, 11 Dec 2020 16:46:01 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3F31B8249980 for ; Fri, 11 Dec 2020 21:46:01 +0000 (UTC) X-FDA: 77582334522.08.shoe99_2b1542627404 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 1BD911819E76B for ; Fri, 11 Dec 2020 21:46:01 +0000 (UTC) X-HE-Tag: shoe99_2b1542627404 X-Filterd-Recvd-Size: 2620 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 21:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hdv0a9V3+tspYcXx56XU7Wm5wIrbtmUO7wb5Jsv2R6w=; b=YOV/+sfeiX8P7/k6vQUAim95bq eXIcRmNVqm7x7jGp0oc1AUtFKlqZPJ2z/J8IwWpIVgsfSUF9e4BOtN4pxVQrAAKYU2zuOZpq+yrzZ 4RTNmaTj1Hsy4hTOqOEHrgOdNYAj7IyAu0cQKn21ky4S/pLvRRM17vNCBvNYQJ0AH9YpjZ8XlmGAK IyMP79AwMrlkwAGi5u9Fxopj/A2LgEgkNLnQw36vPXVzoCuR7OYfxkUXP96ytSMUUpC84SwjxcJ07 WL145WdWK0xqaZy6oW7agjqOYd01ACtnt/CTdVdSdALMB30G9KE/nYAIf/83OCg39tNOQsjtykNbj uJPwPbuw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1knqEa-000655-Qj; Fri, 11 Dec 2020 21:45:52 +0000 Date: Fri, 11 Dec 2020 21:45:52 +0000 From: Matthew Wilcox To: Souptick Joarder Cc: Dan Carpenter , Mike Kravetz , Mina Almasry , Andrew Morton , David Rientjes , Linux-MM , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] hugetlb: Fix an error code in hugetlb_reserve_pages() Message-ID: <20201211214552.GC2443@casper.infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 12, 2020 at 01:19:28AM +0530, Souptick Joarder wrote: > > @@ -5113,6 +5113,7 @@ int hugetlb_reserve_pages(struct inode *inode, > > > > if (unlikely(add < 0)) { > > hugetlb_acct_memory(h, -gbl_reserve); > > + ret = add; > > This function returns int but ret is long type. > Does it need correction ? I wouold say "no", because 'ret' isn't returned _by_ this function (*), its purpose is to capture the return value from other functions. (*) OK, it is, if ret < 0. But ret < 0 really means "Is this an error number", which can be perfectly well represented in an int, short or long. char is too small ;-) So the range of values which will be placed in 'ret' is (-4096-LONG_MAX]