From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA6DC433FE for ; Fri, 11 Dec 2020 20:23:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E74D2074B for ; Fri, 11 Dec 2020 20:23:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E74D2074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A10EE6B0036; Fri, 11 Dec 2020 15:23:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0F56B005C; Fri, 11 Dec 2020 15:23:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88C256B005D; Fri, 11 Dec 2020 15:23:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 6BB356B0036 for ; Fri, 11 Dec 2020 15:23:57 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 35EC0181AC550 for ; Fri, 11 Dec 2020 20:23:57 +0000 (UTC) X-FDA: 77582127714.09.bean81_03173fc27403 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 12D771801C377 for ; Fri, 11 Dec 2020 20:23:57 +0000 (UTC) X-HE-Tag: bean81_03173fc27403 X-Filterd-Recvd-Size: 4351 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 20:23:56 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id k4so7399227qtj.10 for ; Fri, 11 Dec 2020 12:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ELqdRXlB+MjwvvNKBuEm7rQwzLSIQMH5YM/Dpnj0Am0=; b=BxCjNUzeRilpLNFa++B1NsYrYbCN9twqCH3qY3QELZYysTlTjgXGfyhr447n9wmYfO 5aaPIRP7vqa3uynlTB2ZW9HaNgMq/linzUslEIxqMf8IhIwA7rXgncZ7ENiyoJu2c1w0 K8Q+HjqPk4VjfOvFV0RfQcgntEggt9NeEYdn9EH96zhyjMygI3vlV+9PWsTyIHCWJj4j n4I+4Rq6P4/92l064bPU7e+VARtuNHVCE8dt8Biwr3NZtrCka9wwZ5EhrzePVhMqSbg9 CtvRX98LxYchtQNkYXxces3ryzg325UrqmKpOz+2+N+/RQ1uuB9YcH/b6WRZYqSYcCFI dx4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ELqdRXlB+MjwvvNKBuEm7rQwzLSIQMH5YM/Dpnj0Am0=; b=eFr3HOPmugngGHirOyElfEWBtEdNM/Gu+MNUGzHyOQJHktOFRbOf2Dw9ZGP+aDtrkP tylOCFwRvfHzDaLej68HmiCbI5mIABxkaklxBFRgpDXHNaX1R+shFaT4lx3BtV98jcW4 b8uWwbyckaL0lYPeU41kNw/uLe3hvHsiP9POfGa5fH0VeT+ytl/9t74Wmp2qBiH2Hwsq rvWnsbbsP9R2JL9073aTLBvWXIOQBAWCf3mMrRZf0opqFN8vTleR3oCX6MOmRmgZCUqh kaYL7O00oeKnfIF5aOVyXhdLj179xVJN600k8RStXHhY+jDQ+gf0iJu6piZhUMp4oh+O BP1w== X-Gm-Message-State: AOAM532NswQX/SAIJNZ+nhShpeDDu5Xa3FdawPGZVQBYQqT1ahwJ1xyc eU8MBQ3tKo7dvus0n0zWZKm4ng== X-Google-Smtp-Source: ABdhPJy9rue36Wb0wJHhBUETw/119DrBaQGbguszUb9eoNfHAzOrBGwR8fu58hiomMY5ZuNPWOmxWw== X-Received: by 2002:ac8:3ac5:: with SMTP id x63mr17550095qte.376.1607718235945; Fri, 11 Dec 2020 12:23:55 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id 187sm8409820qki.38.2020.12.11.12.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 12:23:55 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1knoxG-009L1i-FW; Fri, 11 Dec 2020 16:23:54 -0400 Date: Fri, 11 Dec 2020 16:23:54 -0400 From: Jason Gunthorpe To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com, sashal@kernel.org, tyhicks@linux.microsoft.com, iamjoonsoo.kim@lge.com, mike.kravetz@oracle.com, rostedt@goodmis.org, mingo@redhat.com, peterz@infradead.org, mgorman@suse.de, willy@infradead.org, rientjes@google.com, jhubbard@nvidia.com, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 5/6] mm/gup: migrate pinned pages out of movable zone Message-ID: <20201211202354.GA2225686@ziepe.ca> References: <20201211202140.396852-1-pasha.tatashin@soleen.com> <20201211202140.396852-6-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211202140.396852-6-pasha.tatashin@soleen.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 11, 2020 at 03:21:39PM -0500, Pavel Tatashin wrote: > @@ -1593,7 +1592,7 @@ static long check_and_migrate_cma_pages(struct mm_struct *mm, > } > > if (!isolate_lru_page(head)) { > - list_add_tail(&head->lru, &cma_page_list); > + list_add_tail(&head->lru, &movable_page_list); > mod_node_page_state(page_pgdat(head), > NR_ISOLATED_ANON + > page_is_file_lru(head), > @@ -1605,7 +1604,7 @@ static long check_and_migrate_cma_pages(struct mm_struct *mm, > i += step; > } > > - if (!list_empty(&cma_page_list)) { > + if (!list_empty(&movable_page_list)) { You didn't answer my earlier question, is it OK that ZONE_MOVABLE pages leak out here if ioslate_lru_page() fails but the moval_page_list is empty? I think the answer is no, right? Jason