From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0853C4361B for ; Fri, 11 Dec 2020 13:36:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64AE723EB1 for ; Fri, 11 Dec 2020 13:36:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64AE723EB1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6333F6B0036; Fri, 11 Dec 2020 08:36:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E3596B005D; Fri, 11 Dec 2020 08:36:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F8C76B0068; Fri, 11 Dec 2020 08:36:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 38A3B6B0036 for ; Fri, 11 Dec 2020 08:36:36 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E07A5824999B for ; Fri, 11 Dec 2020 13:36:35 +0000 (UTC) X-FDA: 77581101150.25.quiet34_21058d427401 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id BF77418046D9A for ; Fri, 11 Dec 2020 13:36:35 +0000 (UTC) X-HE-Tag: quiet34_21058d427401 X-Filterd-Recvd-Size: 3618 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 13:36:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8CFAAE65; Fri, 11 Dec 2020 13:36:33 +0000 (UTC) Date: Fri, 11 Dec 2020 14:36:29 +0100 From: Oscar Salvador To: Muchun Song Cc: corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, almasrymina@google.com, rientjes@google.com, willy@infradead.org, mhocko@suse.com, song.bao.hua@hisilicon.com, david@redhat.com, duanxiongchun@bytedance.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v8 07/12] mm/hugetlb: Set the PageHWPoison to the raw error page Message-ID: <20201211133624.GA27050@linux> References: <20201210035526.38938-1-songmuchun@bytedance.com> <20201210035526.38938-8-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210035526.38938-8-songmuchun@bytedance.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 10, 2020 at 11:55:21AM +0800, Muchun Song wrote: > +static inline void subpage_hwpoison_deliver(struct hstate *h, struct page *head) > +{ > + struct page *page = head; > + > + if (!free_vmemmap_pages_per_hpage(h)) > + return; > + > + if (PageHWPoison(head)) > + page = head + page_private(head + 4); > + > + /* > + * Move PageHWPoison flag from head page to the raw error page, > + * which makes any subpages rather than the error page reusable. > + */ > + if (page != head) { > + SetPageHWPoison(page); > + ClearPageHWPoison(head); > + } > +} I would make the names coherent. I am not definitely goot at names, but something like: hwpoison_subpage_{foo,bar} looks better. Also, could not subpage_hwpoison_deliver be rewritten like: static inline void subpage_hwpoison_deliver(struct hstate *h, struct page *head) { struct page *page; if (!PageHWPoison(head) || !free_vmemmap_pages_per_hpage(h)) return; page = head + page_private(head + 4); /* * Move PageHWPoison flag from head page to the raw error page, * which makes any subpages rather than the error page reusable. */ if (page != head) { SetPageHWPoison(page); ClearPageHWPoison(head); } } I think it is better code-wise. > + * Move PageHWPoison flag from head page to the raw error page, > + * which makes any subpages rather than the error page reusable. > + */ > + if (page != head) { > + SetPageHWPoison(page); > + ClearPageHWPoison(head); > + } I would put this in an else-if above: if (free_vmemmap_pages_per_hpage(h)) { set_page_private(head + 4, page - head); return; } else if (page != head) { SetPageHWPoison(page); ClearPageHWPoison(head); } or will we lose the optimization in case free_vmemmap_pages_per_hpage gets compiled out? -- Oscar Salvador SUSE L3