From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE1AC433FE for ; Thu, 10 Dec 2020 17:44:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58B7A23A33 for ; Thu, 10 Dec 2020 17:44:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58B7A23A33 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A43256B006E; Thu, 10 Dec 2020 12:44:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC186B0070; Thu, 10 Dec 2020 12:44:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 845516B0071; Thu, 10 Dec 2020 12:44:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 64A5F6B006E for ; Thu, 10 Dec 2020 12:44:35 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 16690181AEF31 for ; Thu, 10 Dec 2020 17:44:35 +0000 (UTC) X-FDA: 77578097310.17.suit99_290cfab273fa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id E87A5180D0184 for ; Thu, 10 Dec 2020 17:44:34 +0000 (UTC) X-HE-Tag: suit99_290cfab273fa X-Filterd-Recvd-Size: 3286 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 17:44:33 +0000 (UTC) IronPort-SDR: OpG60s3zO+tBrqPwW/tOg5mClmUu3irK75sWiYwhxu7PagPeSa7wothaSc3guZX4I4x3jOtcA4 asysy4riZIdg== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="238404157" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="238404157" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:44:32 -0800 IronPort-SDR: g09TXIVfLUoyfcVyh7/KNNjhRNq8RoLBtET2ilGBuQ/qIAx5WtulmzIeiJNiZ4zUXea+34HOtt YhFUAwKTL0ig== X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="348897090" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:44:31 -0800 Date: Thu, 10 Dec 2020 09:44:31 -0800 From: Ira Weiny To: Pavel Tatashin Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Jason Gunthorpe , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List Subject: Re: [PATCH v2 3/8] mm/gup: make __gup_longterm_locked common Message-ID: <20201210174431.GT1563847@iweiny-DESK2.sc.intel.com> References: <20201210004335.64634-1-pasha.tatashin@soleen.com> <20201210004335.64634-4-pasha.tatashin@soleen.com> <20201210040618.GR1563847@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 10, 2020 at 08:30:03AM -0500, Pavel Tatashin wrote: > On Wed, Dec 9, 2020 at 11:06 PM Ira Weiny wrote: > > > > On Wed, Dec 09, 2020 at 07:43:30PM -0500, Pavel Tatashin wrote: > > > __gup_longterm_locked() has CMA || FS_DAX version and a common stub > > > version. In the preparation of prohibiting longterm pinning of pages from > > > movable zone make the CMA || FS_DAX version common, and delete the stub > > > version. > > > > I thought Jason sent a patch which got rid of this as well? > > Yes, this series applies on the mainline so it can be easily tested. > The next version, I will sync with linux-next. Oh yea we wanted this to be back-portable correct? If so, LGTM Reviewed-by: Ira Weiny Sorry for not keeping up, Ira