From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15557C433FE for ; Thu, 10 Dec 2020 14:44:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 86B7A22EBE for ; Thu, 10 Dec 2020 14:44:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86B7A22EBE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D76E36B0036; Thu, 10 Dec 2020 09:44:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFE2B6B005D; Thu, 10 Dec 2020 09:44:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA2426B0068; Thu, 10 Dec 2020 09:44:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 9ECF26B0036 for ; Thu, 10 Dec 2020 09:44:35 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 65A6A1EF1 for ; Thu, 10 Dec 2020 14:44:35 +0000 (UTC) X-FDA: 77577643710.15.berry68_550a3b7273f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 410E11814B0C7 for ; Thu, 10 Dec 2020 14:44:35 +0000 (UTC) X-HE-Tag: berry68_550a3b7273f9 X-Filterd-Recvd-Size: 2753 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 14:44:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 49E94ADCD; Thu, 10 Dec 2020 14:44:33 +0000 (UTC) Date: Thu, 10 Dec 2020 15:44:19 +0100 From: Oscar Salvador To: Muchun Song Cc: corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, almasrymina@google.com, rientjes@google.com, willy@infradead.org, mhocko@suse.com, song.bao.hua@hisilicon.com, david@redhat.com, duanxiongchun@bytedance.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v8 04/12] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page Message-ID: <20201210144419.GC8538@localhost.localdomain> References: <20201210035526.38938-1-songmuchun@bytedance.com> <20201210035526.38938-5-songmuchun@bytedance.com> <20201210144256.GB8538@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210144256.GB8538@localhost.localdomain> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 10, 2020 at 03:42:56PM +0100, Oscar Salvador wrote: > On Thu, Dec 10, 2020 at 11:55:18AM +0800, Muchun Song wrote: > > The free_vmemmap_pages_per_hpage() which indicate that how many vmemmap > > pages associated with a HugeTLB page that can be freed to the buddy > > allocator just returns zero now, because all infrastructure is not > > ready. Once all the infrastructure is ready, we will rework this > > function to support the feature. > > I would reword the above to: > > "free_vmemmap_pages_per_hpage(), which indicates how many vmemmap > pages associated with a HugeTLB page can be freed, returns zero for > now, which means the feature is disabled. > We will enable it once all the infrastructure is there." > > Or something along those lines. > > > Signed-off-by: Muchun Song > > Overall this looks good to me, and it has seen a considerable > simplification, which is good. > Some nits/questions below: And as I said, I would merge patch#3 with this one. -- Oscar Salvador SUSE L3