From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E5FFC4361B for ; Wed, 9 Dec 2020 10:02:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E41CE23B79 for ; Wed, 9 Dec 2020 10:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E41CE23B79 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 712906B00D9; Wed, 9 Dec 2020 05:02:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69AA66B00DA; Wed, 9 Dec 2020 05:02:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B0218D000B; Wed, 9 Dec 2020 05:02:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 445726B00D9 for ; Wed, 9 Dec 2020 05:02:47 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0FF971E06 for ; Wed, 9 Dec 2020 10:02:47 +0000 (UTC) X-FDA: 77573304774.14.mice61_5509290273ee Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id E6DC61822987A for ; Wed, 9 Dec 2020 10:02:46 +0000 (UTC) X-HE-Tag: mice61_5509290273ee X-Filterd-Recvd-Size: 2628 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 10:02:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 46372AB63; Wed, 9 Dec 2020 10:02:45 +0000 (UTC) Date: Wed, 9 Dec 2020 11:02:43 +0100 From: Oscar Salvador To: David Hildenbrand Cc: mhocko@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, pasha.tatashin@soleen.com Subject: Re: [RFC PATCH v3 4/4] mm,memory_hotplug: Add mhp_memmap_on_memory boot option Message-ID: <20201209100239.GB30892@linux> References: <20201201115158.22638-1-osalvador@suse.de> <20201201115158.22638-5-osalvador@suse.de> <1cb78e59-d97c-f252-7d1b-e8e9bad38ddd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cb78e59-d97c-f252-7d1b-e8e9bad38ddd@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 02, 2020 at 10:42:18AM +0100, David Hildenbrand wrote: > I have another memhp tunable in the works. I suggest doing it like > page_shuffling and using, module parameters instead. Makes this > a bit nicer IMHO. Does that have any impact? > diff --git a/mm/Makefile b/mm/Makefile > index 069f216e109e..ba7714b5eaa1 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -58,9 +58,13 @@ obj-y := filemap.o mempool.o oom_kill.o fadvise.o \ > page-alloc-y := page_alloc.o > page-alloc-$(CONFIG_SHUFFLE_PAGE_ALLOCATOR) += shuffle.o > > +# Give "memory_hotplug" its own module-parameter namespace > +memory-hotplug-$(CONFIG_MEMORY_HOTPLUG) := memory_hotplug.o > + > obj-y += page-alloc.o > obj-y += init-mm.o > obj-y += memblock.o > +obj-y += $(memory-hotplug-y) > > ifdef CONFIG_MMU > obj-$(CONFIG_ADVISE_SYSCALLS) += madvise.o > @@ -82,7 +86,6 @@ obj-$(CONFIG_SLAB) += slab.o > obj-$(CONFIG_SLUB) += slub.o > obj-$(CONFIG_KASAN) += kasan/ > obj-$(CONFIG_FAILSLAB) += failslab.o > -obj-$(CONFIG_MEMORY_HOTPLUG) += memory_hotplug.o > obj-$(CONFIG_MEMTEST) += memtest.o > obj-$(CONFIG_MIGRATION) += migrate.o > obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o khugepaged.o > > > The you can just use module_param/MODULE_PARM_DESC and set the parameter via > > "memory_hotplug.memmap_on_memory" I have to confess that I was not aware of this trick, but looks cleaner overall. Thanks -- Oscar Salvador SUSE L3