From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA2AC433FE for ; Tue, 8 Dec 2020 18:55:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE98523B52 for ; Tue, 8 Dec 2020 18:55:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE98523B52 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3D6BD6B005D; Tue, 8 Dec 2020 13:55:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 387676B0068; Tue, 8 Dec 2020 13:55:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 250016B006C; Tue, 8 Dec 2020 13:55:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 0C9036B005D for ; Tue, 8 Dec 2020 13:55:44 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B4613181AEF1D for ; Tue, 8 Dec 2020 18:55:43 +0000 (UTC) X-FDA: 77571018966.06.bells43_0d107c2273e9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 2EDDC100410CF for ; Tue, 8 Dec 2020 18:55:43 +0000 (UTC) X-HE-Tag: bells43_0d107c2273e9 X-Filterd-Recvd-Size: 2264 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 18:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W4AcrJtK6ICPNnI9vxGdOXKaQfpdPFgiK/5X2s/GKpg=; b=t9hBCTQ2gC/cRAtFkNGRk31Vi4 tTprtULfcvVf09Oo09i9f4IhgMb/wi22GAhoV0VzXZE9tDfP4156Jx1modMqflxZ+APrZ/Ki+qg7r sId93W28FV0yJZULRzA4UDBCALkDmaY6aLX+CFoUkZNObTGf7wRrqnfict4a60hjoxp9mRn4vpvgR Pn3l6oF7aO8gOiyFMsChRZiSMoFsgPdietSQhmoVGucDf6gYaM1paDmhiHOXrrvEPzC4CqzFbkkmS seK1fbTbhQp+sCU5BkVoZyssBC6KJR/FlNFXpZrQGrMmfYBhHDUx+D4xJ7Wg3cybQkBW2bwUc6j4G Tk9M3cuw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmi94-00029L-8d; Tue, 08 Dec 2020 18:55:30 +0000 Date: Tue, 8 Dec 2020 18:55:30 +0000 From: Matthew Wilcox To: Gerald Schaefer Cc: Mike Kravetz , Andrew Morton , LKML , linux-mm , Christian Borntraeger , Heiko Carstens Subject: Re: [RFC PATCH 1/1] mm/hugetlb: clear compound_nr before freeing gigantic pages Message-ID: <20201208185530.GJ7338@casper.infradead.org> References: <20201208182813.66391-1-gerald.schaefer@linux.ibm.com> <20201208182813.66391-2-gerald.schaefer@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201208182813.66391-2-gerald.schaefer@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000560, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 08, 2020 at 07:28:13PM +0100, Gerald Schaefer wrote: > This is because only the compound_order is cleared in > destroy_compound_gigantic_page(), and compound_nr is set to 1U << order == 1 > for order 0 in set_compound_order(page, 0). I didn't realise there was a separate destroy path for gigantic pages. Thanks for catching and fixing this. Reviewed-by: Matthew Wilcox (Oracle)