From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D42C4361A for ; Sat, 5 Dec 2020 01:25:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 98A9422D75 for ; Sat, 5 Dec 2020 01:25:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98A9422D75 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6E266B0036; Fri, 4 Dec 2020 20:25:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C1E6A6B005D; Fri, 4 Dec 2020 20:25:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B34F56B0068; Fri, 4 Dec 2020 20:25:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 9E41C6B0036 for ; Fri, 4 Dec 2020 20:25:24 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 51B85181AEF30 for ; Sat, 5 Dec 2020 01:25:24 +0000 (UTC) X-FDA: 77557485768.20.table39_1f08979273c9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 3752A180C07AF for ; Sat, 5 Dec 2020 01:25:24 +0000 (UTC) X-HE-Tag: table39_1f08979273c9 X-Filterd-Recvd-Size: 2502 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Dec 2020 01:25:23 +0000 (UTC) Date: Fri, 4 Dec 2020 17:25:21 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1607131522; bh=GjUSlecWxBxHbnsCJmgbVCyqlcg2RO9TS2Mad7tkdB0=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=yg33d0k0YWAbij4DhLtRIMLjs+i8EZqXOsyEVltAzBNjw5EGsvOlonYgvki8qVIyW U7xCaU51IaUJAZQIwOvq+3sCbzFC7rLANXrzEy6aF94x9+2OKhab8IDx/geiwlYie8 t9Orxy/sIjWNmB07TegVDFCJSwNrdqzZ1dd7YdSY= From: Andrew Morton To: Kuan-Ying Lee Cc: "qiang.zhang@windriver.com" , "sfr@canb.auug.org.au" , "aryabinin@virtuozzo.com" , "dvyukov@google.com" , "andreyknvl@google.com" , "qcai@redhat.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Subject: Re: [PATCH] kasan: fix slab double free when cpu-hotplug Message-Id: <20201204172521.ed9f77164ff9f9fc91f35ee0@linux-foundation.org> In-Reply-To: <1607083295.22062.15.camel@mtksdccf07> References: <20201204102206.20237-1-qiang.zhang@windriver.com> <1607083295.22062.15.camel@mtksdccf07> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying Lee wrote: > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > > index d98b516f372f..55783125a767 100644 > > --- a/mm/kasan/quarantine.c > > +++ b/mm/kasan/quarantine.c > > @@ -194,7 +194,6 @@ bool quarantine_put(struct kmem_cache *cache, void *object) > > > > q = this_cpu_ptr(&cpu_quarantine); > > if (q->offline) { > > - qlink_free(&meta->quarantine_link, cache); > > local_irq_restore(flags); > > return false; > > } > > Hi Qiang, > > Thanks for fixing this. > Due to that issue, my commit has been removed by Stephen from > linux-next. > > > Hi Stephen, Andrew, > > Should I directly upload the v4 or Stephen can pick the commit which > has been removed back to the linux-next. I took care of it. Restored the original patch and added this one as a -fix.