From: Andrew Morton <akpm@linux-foundation.org>
To: Liu Zixian <liuzixian4@huawei.com>
Cc: <linmiaohe@huawei.com>, <louhongxiang@huawei.com>,
<linux-mm@kvack.org>, <hushiyuan@huawei.com>,
<stable@vger.kernel.org>, David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v2] fix mmap return value when vma is merged after call_mmap()
Date: Thu, 3 Dec 2020 14:25:37 -0800 [thread overview]
Message-ID: <20201203142537.c69ab696573e63d54becff07@linux-foundation.org> (raw)
In-Reply-To: <20201203085350.22624-1-liuzixian4@huawei.com>
On Thu, 3 Dec 2020 16:53:50 +0800 Liu Zixian <liuzixian4@huawei.com> wrote:
> On success, mmap should return the begin address of newly mapped area,
> but patch "mm: mmap: merge vma after call_mmap() if possible"
> set vm_start of newly merged vma to return value addr.
> Users of mmap will get wrong address if vma is merged after call_mmap().
> We fix this by moving the assignment to addr before merging vma.
Let's cc David and Jason, as they commented on v1.
You cc'ed stable@vger.kernel.org on the email, but there's no
cc:stable@vger.kernel.org in the changelog tags. There should be.
Has this bug actually been observed at runtime, or is it a theoretical
from-code-inspection thing?
next prev parent reply other threads:[~2020-12-03 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 8:53 Liu Zixian
2020-12-03 22:25 ` Andrew Morton [this message]
2020-12-04 2:29 ` Liu Zixian
2020-12-04 14:11 ` David Hildenbrand
2020-12-04 15:10 ` Jason Gunthorpe
2020-12-04 15:25 ` Matthew Wilcox
2020-12-04 16:04 ` Jason Gunthorpe
2020-12-04 19:53 ` Matthew Wilcox
2020-12-04 15:11 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203142537.c69ab696573e63d54becff07@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hushiyuan@huawei.com \
--cc=jgg@ziepe.ca \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=liuzixian4@huawei.com \
--cc=louhongxiang@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox