From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A3BC4361B for ; Thu, 3 Dec 2020 20:49:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7501F221EC for ; Thu, 3 Dec 2020 20:49:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7501F221EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7FC276B0036; Thu, 3 Dec 2020 15:49:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 784EF6B005C; Thu, 3 Dec 2020 15:49:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64D538D0001; Thu, 3 Dec 2020 15:49:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 4F43B6B0036 for ; Thu, 3 Dec 2020 15:49:19 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1D73D1EFD for ; Thu, 3 Dec 2020 20:49:19 +0000 (UTC) X-FDA: 77553161238.26.net42_5a0bb74273be Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id EB60E1804B65A for ; Thu, 3 Dec 2020 20:49:18 +0000 (UTC) X-HE-Tag: net42_5a0bb74273be X-Filterd-Recvd-Size: 3600 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Dec 2020 20:49:18 +0000 (UTC) Date: Thu, 3 Dec 2020 12:49:14 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1607028557; bh=Iz54XglcOoe77jtz7VvpJX1zZYveIrI7EDKyUjAzBNE=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=gxZrBLg1g38jqJHt+4TRxSacQbXjfAQyuNgBBZy/cHOBt0sXTYgy/SY+E87Kr7A9h tFbME0BPQ1cog44iqdXw5RjgsNxbHMs84gS8XcDB3hspHs3AN4ciqPywFHnHriekqe +t5UDh5+9/BvJElIScMwNeWi/GHHDLWAYKDfnpIU= From: Andrew Morton To: alex.popov@linux.com Cc: Alexander Potapenko , Kees Cook , Jann Horn , Will Deacon , Andrey Ryabinin , Dmitry Vyukov , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Masahiro Yamada , Masami Hiramatsu , Steven Rostedt , Peter Zijlstra , Krzysztof Kozlowski , Patrick Bellasi , David Howells , Eric Biederman , Johannes Weiner , Laura Abbott , Arnd Bergmann , Greg Kroah-Hartman , Daniel Micay , Andrey Konovalov , Matthew Wilcox , Pavel Machek , Valentin Schneider , kasan-dev , Linux Memory Management List , Kernel Hardening , LKML , notify@kernel.org Subject: Re: [PATCH RFC v2 2/6] mm/slab: Perform init_on_free earlier Message-Id: <20201203124914.25e63b013e9c69c79d481831@linux-foundation.org> In-Reply-To: <1772bc7d-e87f-0f62-52a8-e9d9ac99f5e3@linux.com> References: <20200929183513.380760-1-alex.popov@linux.com> <20200929183513.380760-3-alex.popov@linux.com> <1772bc7d-e87f-0f62-52a8-e9d9ac99f5e3@linux.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 3 Dec 2020 22:50:27 +0300 Alexander Popov wrote: > On 30.09.2020 15:50, Alexander Potapenko wrote: > > On Tue, Sep 29, 2020 at 8:35 PM Alexander Popov wrote: > >> > >> Currently in CONFIG_SLAB init_on_free happens too late, and heap > >> objects go to the heap quarantine being dirty. Lets move memory > >> clearing before calling kasan_slab_free() to fix that. > >> > >> Signed-off-by: Alexander Popov > > Reviewed-by: Alexander Potapenko > > Hello! > > Can this particular patch be considered for the mainline kernel? All patches are considered ;) And merged if they're reviewed, tested, judged useful, etc. If you think this particular patch should be fast-tracked then please send it as a non-RFC, standalone patch. Please also enhance the changelog so that it actually explains what goes wrong. Presumably "objects go to the heap quarantine being dirty" causes some user-visible problem? What is that problem?