From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C531C64E7B for ; Wed, 2 Dec 2020 16:30:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3455B21D81 for ; Wed, 2 Dec 2020 16:30:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3455B21D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 67E108D0005; Wed, 2 Dec 2020 11:30:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62EAD8D0002; Wed, 2 Dec 2020 11:30:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5272D8D0005; Wed, 2 Dec 2020 11:30:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 3C6748D0002 for ; Wed, 2 Dec 2020 11:30:01 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EE63B180AD830 for ; Wed, 2 Dec 2020 16:30:00 +0000 (UTC) X-FDA: 77548878960.13.slip90_380ad72273b4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id C879518140B60 for ; Wed, 2 Dec 2020 16:30:00 +0000 (UTC) X-HE-Tag: slip90_380ad72273b4 X-Filterd-Recvd-Size: 4135 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 16:30:00 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id ek7so963912qvb.6 for ; Wed, 02 Dec 2020 08:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=w4g3S+xlvIrCO+/FOV5OgRZ1thWmRnYhNOzF2Xs2/Eo=; b=d593bOeGHr1UExK12z4v5kr/85o2IKxmpnz32AaGX6Sh+5FEVrsugMFhbD/M/XQ3Kx DvsjiqkVfbvhZRQ6bbAftq0a7Xw0EdPkgOUTz+kHJjP3IAP+vbkZPL53z/IOzJzIJGCd zObndtxrY8ZMdbv8hXRvnMTG/UiUVgb3/ypdPhU+ksPFPlpqOMzKxq+UH/N4/yrN++Wt 0nTDHpNNAFcP9a/ntlTaBZB0G5qhyL11No1riKk6dg5JtyCFw4rrvoXfLcQJPzOoGsow pFBxFvFo7hb0C/eN8d2xGwMPsu9ZYGaZM6++ARd9Po9qn25drvuAy/Hs3bQf43ozKp40 JLFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=w4g3S+xlvIrCO+/FOV5OgRZ1thWmRnYhNOzF2Xs2/Eo=; b=Zlj4ha8soTC/1j3MQ6vDC/rjMIwuEXW81i4dnQXiS4ZPdEQEJtMSCHyB6hx7IFd2mX TAV6TCh0UeJWu8hJeP8sLDdl5D1mewe2FglMoD1Jp/4POIOMZMqjQ4jlLQYDHD40gT/L 4ODcRmm+eHNCGkni0p7u6UtWM9C0ROyqPIfLf+Vt5sDM4yflifpVZCH7OjcJXkq9YPm9 vMmE/36RWyHhSUa2JvUPztCJMKMkao0ThzPUMg0qwiO37Xw2f6oVRk4RU1x1MpVPMa+3 fbPu7EinUjMFj99PrqnpoefWQStZI98Ejb5pSWznsQUVAzmVLrm4wPR4UJhdvEXvz+7x AZgA== X-Gm-Message-State: AOAM533vcuCzkcWamAQKnxLis0Im9Nl75jiWwicutL1dQ0NXYRBL2NuL PlCaD6PgSYw3SZIO7me8l8gUjQ== X-Google-Smtp-Source: ABdhPJwrq09bfNPIrJ1rBBIxaEY6e7dgZTuxYSKii2fZiyNDBHOMOn0rKKInR7tVkslrutd4L2h9dA== X-Received: by 2002:a0c:abc8:: with SMTP id k8mr3597913qvb.14.1606926599556; Wed, 02 Dec 2020 08:29:59 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id s130sm1398639qka.91.2020.12.02.08.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 08:29:58 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kkV0w-0056jV-4Q; Wed, 02 Dec 2020 12:29:58 -0400 Date: Wed, 2 Dec 2020 12:29:58 -0400 From: Jason Gunthorpe To: Pavel Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com, sashal@kernel.org, tyhicks@linux.microsoft.com, iamjoonsoo.kim@lge.com, mike.kravetz@oracle.com, rostedt@goodmis.org, mingo@redhat.com, peterz@infradead.org, mgorman@suse.de, willy@infradead.org, rientjes@google.com, jhubbard@nvidia.com Subject: Re: [PATCH 1/6] mm/gup: perform check_dax_vmas only when FS_DAX is enabled Message-ID: <20201202162958.GK5487@ziepe.ca> References: <20201202052330.474592-1-pasha.tatashin@soleen.com> <20201202052330.474592-2-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201202052330.474592-2-pasha.tatashin@soleen.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 02, 2020 at 12:23:25AM -0500, Pavel Tatashin wrote: > There is no need to check_dax_vmas() and run through the npage loop of > pinned pages if FS_DAX is not enabled. >=20 > Add a stub check_dax_vmas() function for no-FS_DAX case. >=20 > Signed-off-by: Pavel Tatashin > ---=00 > mm/gup.c | 7 +++++++ > 1 file changed, 7 insertions(+) I have a patch to delete check_dax_vmas that is just waiting on me to figure out how to test with dax. That makes all this ifdefery much simpler Jason