From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E599FC6369E for ; Wed, 2 Dec 2020 23:16:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B581221FB for ; Wed, 2 Dec 2020 23:16:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B581221FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35AE96B005C; Wed, 2 Dec 2020 18:16:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E43B6B005D; Wed, 2 Dec 2020 18:16:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1859E6B0068; Wed, 2 Dec 2020 18:16:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 020D96B005C for ; Wed, 2 Dec 2020 18:15:59 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BE4B23636 for ; Wed, 2 Dec 2020 23:15:59 +0000 (UTC) X-FDA: 77549902038.10.sofa24_030d148273b7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 9F63B16A4AA for ; Wed, 2 Dec 2020 23:15:59 +0000 (UTC) X-HE-Tag: sofa24_030d148273b7 X-Filterd-Recvd-Size: 1517 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 23:15:59 +0000 (UTC) Date: Wed, 2 Dec 2020 15:15:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1606950957; bh=GIxDqD7uyqfqU0/Yhag9Aqk11nRK5ZDPMst72hACnKs=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=oMYRn4E54/4EJ2VENB7SaShDI/g86o6N/JdhUoTDOC5VmHLSl4punLBvaX5v7Euf9 9hGlahpHiYLijD46ROM026BV78121kP/7FN//sdG5r7agDQPf0a7aDgRq5lfOva2yA 2jCVgxmEf0igttv5F9MDtQMS8PwsLuwGfytOqjSI= From: Andrew Morton To: Qian Cai Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held Message-Id: <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> In-Reply-To: <20201202151549.10350-1-qcai@redhat.com> References: <20201202151549.10350-1-qcai@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > We can't call kvfree() with a spin lock held, so defer it. > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct allocatio n") Do you think it's worth a cc:stable? IOW, is this known to ever produce a warning? (If not, why did we need 873d7bcfd066??)