From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35B1C64E7B for ; Mon, 30 Nov 2020 20:21:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 139922074A for ; Mon, 30 Nov 2020 20:21:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="VVHdgPlR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 139922074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 697A06B0036; Mon, 30 Nov 2020 15:21:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64AA58D0002; Mon, 30 Nov 2020 15:21:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 538A38D0001; Mon, 30 Nov 2020 15:21:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 39C006B0036 for ; Mon, 30 Nov 2020 15:21:19 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 06DC98249980 for ; Mon, 30 Nov 2020 20:21:19 +0000 (UTC) X-FDA: 77542204278.07.rain46_0e0f08f273a4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id E1B1E1803F9BF for ; Mon, 30 Nov 2020 20:21:18 +0000 (UTC) X-HE-Tag: rain46_0e0f08f273a4 X-Filterd-Recvd-Size: 4386 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Nov 2020 20:21:17 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id h20so12171811qkk.4 for ; Mon, 30 Nov 2020 12:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gQQl36bXbclaKmYcyW6UZ4zFh+yStxJW/hv74bT5Djw=; b=VVHdgPlRXPjsdbqs5gCcCgE8hcY8metarP3X7+/uf9GM+Ko/Tc9SglDgnMNSBY2P3b by6Na/JFIpSUAQDRrw3MJJCVxSpqDZbIKuVG2JTEnHrc6+cUJRpZCwjZQJki/FNFCNEQ CMZWLaYGkfo+R/7a+DVidSUSU/wBAYqaF235YAMgogBmLHDx7g08hNTQqZ58l1wEz28O W4bv+QXOtAKLhylZyN0zXfSU1xukXbYa+jHDK1QLF59cKDo9zc90zUPqk5+Dr/Bk61pN d3+QkPBpShLjargpQP72wKy32/UcNOCjoiJb0fk7E1w021eRX0szWxPESlglmv3plU4l EZkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gQQl36bXbclaKmYcyW6UZ4zFh+yStxJW/hv74bT5Djw=; b=DlcGhV5XzCvJt80lsYexuveE0yYJGHlGzTByr8QguQ+MJnG0YsNQQJUP9LCP7TJbNx cyqjRbLKjBWVmOrFXvz5/bzqJazMjxdYXPgcBO096LpyRPwKZSoUX6Yk164GPpeQxknw mNYrAjIfgGR2ODJXjMHSDP5Ap1eiZ6OdkydvyGDiLPs+CcbPBOeT1SmQwE+VGiQ7lQKy 3DxZRYJAui7YBYU5epzBTULI3MAtDGS9TREDQRYokWIaaEAbsyeNBcFLli2KBlI9DVfn 6+NJvg7YsjHoPu+MexYxKEZsnPmkBFYtbc8ONVBQNbhpvJLmS8wHiqmAcluyuKAZZj+L 0Rlw== X-Gm-Message-State: AOAM5304liYyNpNdT9GURvzB9c9FwQL9eS2zgD5U0+1Ww+cCYhHlXbL3 Wv++MpctR2Uiymf2Hi4we07l+Q== X-Google-Smtp-Source: ABdhPJx9wyf4xusg06LfP6yiei1fwWA0412KhJR+Nt4TedyjjjcVx3oaFOXwIXEnjmnLaG+qAWewFw== X-Received: by 2002:a37:e215:: with SMTP id g21mr7736404qki.91.1606767676845; Mon, 30 Nov 2020 12:21:16 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:a2bc]) by smtp.gmail.com with ESMTPSA id 199sm16701507qkm.62.2020.11.30.12.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 12:21:16 -0800 (PST) Date: Mon, 30 Nov 2020 15:19:16 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Roman Gushchin , Michal Hocko , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: memcontrol: account pagetables per node Message-ID: <20201130201916.GB23216@cmpxchg.org> References: <20201126005603.1293012-1-shakeelb@google.com> <20201126005603.1293012-3-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126005603.1293012-3-shakeelb@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 04:56:03PM -0800, Shakeel Butt wrote: > For many workloads, pagetable consumption is significant and it makes > sense to expose it in the memory.stat for the memory cgroups. However at > the moment, the pagetables are accounted per-zone. Converting them to > per-node and using the right interface will correctly account for the > memory cgroups as well. > > Signed-off-by: Shakeel Butt Agreed, this is a useful stat item to have. Just one trivial issue: > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -151,7 +151,6 @@ enum zone_stat_item { > NR_ZONE_UNEVICTABLE, > NR_ZONE_WRITE_PENDING, /* Count of dirty, writeback and unstable pages */ > NR_MLOCK, /* mlock()ed pages found and moved off LRU */ > - NR_PAGETABLE, /* used for pagetables */ > /* Second 128 byte cacheline */ > NR_BOUNCE, > #if IS_ENABLED(CONFIG_ZSMALLOC) > @@ -206,6 +205,7 @@ enum node_stat_item { > #if IS_ENABLED(CONFIG_SHADOW_CALL_STACK) > NR_KERNEL_SCS_KB, /* measured in KiB */ > #endif > + NR_PAGETABLE, /* used for pagetables */ > NR_VM_NODE_STAT_ITEMS > }; You need to update mm/vmstat.c::vmstat_text accordingly or /proc/vmstat output will be bogus. With that fixed, please feel free to add: Acked-by: Johannes Weiner