From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DA7C63777 for ; Mon, 30 Nov 2020 20:11:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36A6F206CA for ; Mon, 30 Nov 2020 20:11:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="OD8itAkk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A6F206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98DB56B0036; Mon, 30 Nov 2020 15:11:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93E948D0002; Mon, 30 Nov 2020 15:11:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B7788D0001; Mon, 30 Nov 2020 15:11:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 60ADA6B0036 for ; Mon, 30 Nov 2020 15:11:26 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 27A46181AEF00 for ; Mon, 30 Nov 2020 20:11:26 +0000 (UTC) X-FDA: 77542179372.30.loss73_3708d7b273a4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D7F52180B3C83 for ; Mon, 30 Nov 2020 20:11:25 +0000 (UTC) X-HE-Tag: loss73_3708d7b273a4 X-Filterd-Recvd-Size: 3696 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Nov 2020 20:11:25 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id q5so12109932qkc.12 for ; Mon, 30 Nov 2020 12:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kO3c8jFNnrYhfTQFD83uebtL85zMmeqUHdIq74926tg=; b=OD8itAkkawtanACkX7JR3tnKgtLsPw2EElv+hh9ks7Nl2nBXQPuvN1RTNAYWEf/IUb rkib84IKKNdxTgWU4dJiU2OegjB23HQyL3627Ib2GV2eHfnRqWePZ7EXikxJWi/VYQNT lG3rZMbWaZJs78dGkhTy832j5fPWqzaJM0qqT99VZT6Ld8cp6p5VAdTZ/AfgTu1p/rQq BzG72jRIvu/I8INEwHHjUOrBetpbVMCeLRKf30x5bgIfyiTzT2z3mR/llagRuKX+sJn1 eiuQKWtSF0wbVXEev3KEkxrYg0RaJ17kKAP9bJICKm7m60oEbWL3g93gfVaPKb6m+KIc EJkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kO3c8jFNnrYhfTQFD83uebtL85zMmeqUHdIq74926tg=; b=dO62dhduSbAYCN8LO32vR5Iiu4rqG4AA9/BeghWYrQ9G51qEhS0AvLHIPferdT/EgC xcM09AyhQkQN9ZvVCz4J/XdyMxR+IDmIXoRZdOyTd4wNnuZobBBL+AUIJ/6CjHTzsuuz nAmQPsu3wcATkDaWDVButQpdzuyxf2Cc0U6ZT5ITTsIhxhE9vSrJoXnk1mYLG9h1Qqe0 XLW04ppgRkg0B8sp4Ft+IanW477pTscq90rl7nbPUA/mlbWAJcWEAWrDHoDjXc57Aj39 Zd/wsXf72qMZl95m/sSzLwimTRTJxdZQ93cAGvWnK9oKzqkzwScJXnWZUuPCk3aOgib4 3OHQ== X-Gm-Message-State: AOAM532PIquRykcMxbYpZnvoY12Knopo2E+Tz4nc5mXRJqt6yAoXnWAx u0q6hVDC4O0/QvUXOx6UboPZqA== X-Google-Smtp-Source: ABdhPJyvDjiXAk712YRtI7P2vu5RDjLQk0Mje3emoELHeH3xj4jp2rg4jtolQFilf+zU92UMT6w6tg== X-Received: by 2002:a05:620a:2202:: with SMTP id m2mr24385531qkh.251.1606767084496; Mon, 30 Nov 2020 12:11:24 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:a2bc]) by smtp.gmail.com with ESMTPSA id w54sm17820460qtb.0.2020.11.30.12.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 12:11:23 -0800 (PST) Date: Mon, 30 Nov 2020 15:09:22 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Roman Gushchin , Michal Hocko , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: move lruvec stats update functions to vmstat.h Message-ID: <20201130200922.GA23216@cmpxchg.org> References: <20201126005603.1293012-1-shakeelb@google.com> <20201126005603.1293012-2-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126005603.1293012-2-shakeelb@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 04:56:02PM -0800, Shakeel Butt wrote: > This patch does not change any functionality and only move the functions > which update the lruvec stats to vmstat.h from memcontrol.h. The main > reason for this patch is to be able to use these functions in the page > table contructor function which is defined in mm.h and we can not > include the memcontrol.h in that file. > > Signed-off-by: Shakeel Butt This is a better place for this interface in general. The lruvec abstraction, while invented for memcg, isn't specific to memcg at all. Acked-by: Johannes Weiner