From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E3BC64E7B for ; Mon, 30 Nov 2020 14:21:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46AA8206CB for ; Mon, 30 Nov 2020 14:21:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DulYgDsb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46AA8206CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 530758D0002; Mon, 30 Nov 2020 09:21:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B9028D0001; Mon, 30 Nov 2020 09:21:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359D38D0002; Mon, 30 Nov 2020 09:21:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 1CEE38D0001 for ; Mon, 30 Nov 2020 09:21:27 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CAB8A8249980 for ; Mon, 30 Nov 2020 14:21:26 +0000 (UTC) X-FDA: 77541297372.22.heat79_230d4f6273a2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 37A4F18037397 for ; Mon, 30 Nov 2020 14:21:26 +0000 (UTC) X-HE-Tag: heat79_230d4f6273a2 X-Filterd-Recvd-Size: 3493 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Nov 2020 14:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XfECwCYY95Uh3FJvumBnHWCMSCcNGHqYoDsLHJkgtmY=; b=DulYgDsbWnEyuLXmSBSFxAmVBD rzrMvEJrYA9iHJHu9cRKjC2MzjPvqfJhm4526H65Og1e6HLgPYAtR5rYblt1wlv1mjhmNVjvB0fp1 hZDo3BQt1oNO98JPp3NmUH2+bLgqJ3TOHbL4gEMHD5RYcmmapLIp5+m4XQtWq2O2ERC/rE0AsltKH lzECodsfo0Qo9CU5Ed5Ctb6Jwcn66WEfcOm5fwKQIXJ8VkD1JMaqqcI15klEx+wrgCJ+/78do6vRk LQifYfrEPUdrmsbv6Xn+7RWcNNyYFnwWKUyMbmkJxQEIgQXdSlq+YZxx7tKO1GdEOjGYxVxhd7Bnn kkVE9upA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjk3M-0000hQ-4Y; Mon, 30 Nov 2020 14:21:20 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D080330477A; Mon, 30 Nov 2020 15:21:18 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C1936203DFA1C; Mon, 30 Nov 2020 15:21:18 +0100 (CET) Date: Mon, 30 Nov 2020 15:21:18 +0100 From: Peter Zijlstra To: David Laight Cc: "x86@kernel.org" , "willy@infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "aarcange@redhat.com" , "kirill.shutemov@linux.intel.com" , "jroedel@suse.de" Subject: Re: [RFC][PATCH 3/9] sh/mm: Make pmd_t similar to pte_t Message-ID: <20201130142118.GO2414@hirez.programming.kicks-ass.net> References: <20201130112705.900705277@infradead.org> <20201130113602.959570640@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 30, 2020 at 02:10:42PM +0000, David Laight wrote: > From: Peter Zijlstra > > Sent: 30 November 2020 11:27 > > > > Just like 64bit pte_t, have a low/high split in pmd_t. > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > > arch/sh/include/asm/pgtable-3level.h | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > --- a/arch/sh/include/asm/pgtable-3level.h > > +++ b/arch/sh/include/asm/pgtable-3level.h > > @@ -28,9 +28,15 @@ > > #define pmd_ERROR(e) \ > > printk("%s:%d: bad pmd %016llx.\n", __FILE__, __LINE__, pmd_val(e)) > > > > -typedef struct { unsigned long long pmd; } pmd_t; > > +typedef struct { > > + struct { > > + unsigned long pmd_low; > > + unsigned long pmd_high; > > + }; > > + unsigned long long pmd; > > +} pmd_t; > > Would it be better to use u32 and u64? That would be inconsistent with the rest of SH. If you want to go clean up SH, have at, but that's not what this series is for.