From: Peter Zijlstra <peterz@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mohamed Alzayat <alzayat@mpi-sws.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org, Will Deacon <will@kernel.org>
Subject: Re: Potential bug in soft-dirty bits (with test case)
Date: Mon, 30 Nov 2020 13:02:41 +0100 [thread overview]
Message-ID: <20201130120241.GP3040@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <2e60ad6d-7bdf-e19e-4ad9-6942f76088d3@suse.cz>
On Mon, Nov 30, 2020 at 12:51:59PM +0100, Vlastimil Babka wrote:
> On 11/30/20 11:37 AM, Mohamed Alzayat wrote:
> > Thanks for confirming, Vlastimil!
> >
> > The first bad commit is: 0758cd8304942292e95a0f750c374533db378b32
> > asm-generic/tlb: avoid potential double flush
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0758cd8304942292e95a0f750c374533db378b32
> >
> > Reverting this commit solves the problem, but this might not be the
> > right way of fixing it.
>
> Thanks for bisecting! Let's CC people involved in that commit. All important
> should be in the quoted conversation above.
There's a thread about it here:
https://lkml.kernel.org/r/20201120143557.6715-1-will@kernel.org
That softdirty code really shouldn't be using mmu_gather imo, but I'm
still not clear on what exactly is broken why there.
next prev parent reply other threads:[~2020-11-30 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 14:15 Mohamed Alzayat
2020-11-27 16:40 ` Vlastimil Babka
2020-11-30 10:37 ` Mohamed Alzayat
2020-11-30 11:51 ` Vlastimil Babka
2020-11-30 12:02 ` Peter Zijlstra [this message]
2020-11-30 12:50 ` Will Deacon
2021-04-20 18:32 ` Mohamed Alzayat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130120241.GP3040@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alzayat@mpi-sws.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox