From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6640C63777 for ; Fri, 27 Nov 2020 07:20:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C1DD221EB for ; Fri, 27 Nov 2020 07:20:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C1DD221EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED55D6B005C; Fri, 27 Nov 2020 02:20:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E84836B006C; Fri, 27 Nov 2020 02:20:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B856B006E; Fri, 27 Nov 2020 02:20:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id C4D986B005C for ; Fri, 27 Nov 2020 02:20:25 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7C21D180AD81D for ; Fri, 27 Nov 2020 07:20:25 +0000 (UTC) X-FDA: 77529350010.13.stove50_451498127386 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 5D24C18140B60 for ; Fri, 27 Nov 2020 07:20:25 +0000 (UTC) X-HE-Tag: stove50_451498127386 X-Filterd-Recvd-Size: 1780 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Nov 2020 07:20:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 66E47AC17; Fri, 27 Nov 2020 07:20:23 +0000 (UTC) Date: Fri, 27 Nov 2020 08:20:21 +0100 From: Oscar Salvador To: Vlastimil Babka Cc: akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] mm,hwpoison: Remove drain_all_pages from shake_page Message-ID: <20201127072021.GA3999@localhost.localdomain> References: <20201119105716.5962-1-osalvador@suse.de> <20201119105716.5962-8-osalvador@suse.de> <4033449e-eb86-e306-81af-d4c6dc823bdf@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4033449e-eb86-e306-81af-d4c6dc823bdf@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 26, 2020 at 02:52:32PM +0100, Vlastimil Babka wrote: > > @@ -275,9 +275,6 @@ void shake_page(struct page *p, int access) > > lru_add_drain_all(); > > if (PageLRU(p)) > > return; > > - drain_all_pages(page_zone(p)); > > - if (PageLRU(p) || is_free_buddy_page(p)) > > - return; > > I wonder if page in the lru pagevec can in fact become free after draining > the lru - in that case we could keep the is_free_buddy_page() check. Uhm, yes, I think it can happen. After all, once the page hits one of the inactives' LRU it can be reclaimed. I am fine with joining the left PageLRU and is_free_buddy_page check. Will do that in the next revision. Thanks! -- Oscar Salvador SUSE L3