From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B08EC56202 for ; Thu, 26 Nov 2020 16:56:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA607221EB for ; Thu, 26 Nov 2020 16:56:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA607221EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B42B6B0072; Thu, 26 Nov 2020 11:56:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33D1F6B0073; Thu, 26 Nov 2020 11:56:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 253116B0074; Thu, 26 Nov 2020 11:56:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 0FAE46B0072 for ; Thu, 26 Nov 2020 11:56:44 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C0F80181AEF30 for ; Thu, 26 Nov 2020 16:56:43 +0000 (UTC) X-FDA: 77527173486.19.ducks19_1a0259327380 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id A668C1ACEBC for ; Thu, 26 Nov 2020 16:56:43 +0000 (UTC) X-HE-Tag: ducks19_1a0259327380 X-Filterd-Recvd-Size: 2364 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 16:56:43 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 00CC4AD20; Thu, 26 Nov 2020 16:56:42 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 841961E10D0; Thu, 26 Nov 2020 17:56:41 +0100 (CET) Date: Thu, 26 Nov 2020 17:56:41 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 31/44] block: move the start_sect field to struct block_device Message-ID: <20201126165641.GQ422@quack2.suse.cz> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-32-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126130422.92945-32-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 26-11-20 14:04:09, Christoph Hellwig wrote: > Move the start_sect field to struct block_device in preparation > of killing struct hd_struct. > > Signed-off-by: Christoph Hellwig Looks good, just one nit below. Feel free to add: Reviewed-by: Jan Kara > diff --git a/block/partitions/core.c b/block/partitions/core.c > index 8924e1ea8b2ad6..485777cea26bfa 100644 > --- a/block/partitions/core.c > +++ b/block/partitions/core.c > @@ -192,7 +192,7 @@ static ssize_t part_start_show(struct device *dev, > { > struct hd_struct *p = dev_to_part(dev); > > - return sprintf(buf, "%llu\n",(unsigned long long)p->start_sect); > + return sprintf(buf, "%llu\n",(unsigned long long)p->bdev->bd_start_sect); The long long conversion is pointless here, right? Honza -- Jan Kara SUSE Labs, CR