From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33379C64E75 for ; Thu, 26 Nov 2020 15:07:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F26621D46 for ; Thu, 26 Nov 2020 15:07:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F26621D46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A22B56B0075; Thu, 26 Nov 2020 10:07:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D32C6B0078; Thu, 26 Nov 2020 10:07:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90FE46B007B; Thu, 26 Nov 2020 10:07:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 7B64B6B0075 for ; Thu, 26 Nov 2020 10:07:57 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3BB148249980 for ; Thu, 26 Nov 2020 15:07:57 +0000 (UTC) X-FDA: 77526899394.16.glass74_480e0ba27380 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 173E3100E6903 for ; Thu, 26 Nov 2020 15:07:57 +0000 (UTC) X-HE-Tag: glass74_480e0ba27380 X-Filterd-Recvd-Size: 2811 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 15:07:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5E206ACE0; Thu, 26 Nov 2020 15:07:55 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 2EBF11E10D0; Thu, 26 Nov 2020 16:07:55 +0100 (CET) Date: Thu, 26 Nov 2020 16:07:55 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 22/44] block: opencode devcgroup_inode_permission Message-ID: <20201126150755.GI422@quack2.suse.cz> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-23-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126130422.92945-23-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 26-11-20 14:04:00, Christoph Hellwig wrote: > Just call devcgroup_check_permission to avoid various superflous checks > and a double conversion of the access flags. > > Signed-off-by: Christoph Hellwig > Acked-by: Tejun Heo Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/block_dev.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index d0783c55a0ce65..b12ab68297baf3 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -1516,15 +1516,13 @@ static int blkdev_get(struct block_device *bdev, fmode_t mode, void *holder) > struct block_device *claiming; > bool unblock_events = true; > struct gendisk *disk; > - int perm = 0; > int partno; > int ret; > > - if (mode & FMODE_READ) > - perm |= MAY_READ; > - if (mode & FMODE_WRITE) > - perm |= MAY_WRITE; > - ret = devcgroup_inode_permission(bdev->bd_inode, perm); > + ret = devcgroup_check_permission(DEVCG_DEV_BLOCK, > + imajor(bdev->bd_inode), iminor(bdev->bd_inode), > + ((mode & FMODE_READ) ? DEVCG_ACC_READ : 0) | > + ((mode & FMODE_WRITE) ? DEVCG_ACC_WRITE : 0)); > if (ret) > goto bdput; > > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR